Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Do the JSPs really need a version number? #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
eggrobin opened this issue May 20, 2025 · 1 comment
Open

Do the JSPs really need a version number? #1154

eggrobin opened this issue May 20, 2025 · 1 comment

Comments

@eggrobin
Copy link
Member

While deploying #1152, I looked at the footer, which now says

Version 3.9; ICU version: 76.1; Unicode/Emoji version: 16.0.0; Unicodeβ version: 17.0.0; • source

That Version 3.9 is hardcoded, and has been stuck at 3.9 for seven years, since 1c6fa74 (previously it was 3.8).

It might be useful to put the git commit in there instead.
@macchiati
Copy link
Member

Good idea. But I suggest also the date of the commit, since that will be more informative for people not on the dev spectrum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eggrobin @macchiati