chore(jsp): © / TOU on footer, also mention source #1152
Conversation
- copyright and terms of use on util.unicode.org footer and help page - link to source repo Fixes: #1015
| <!-- yes, UTF-8 issue here, so using © --> | ||
| © 2001-<%= Year.now() %> Unicode, Inc. Unicode and the Unicode Logo are registered trademarks of Unicode, Inc. in | ||
| the U.S. and other countries. See <a href="https://www.unicode.org/copyright.html">Terms of Use</a>. |
There was a problem hiding this comment.
Should this say "For terms of use and license" as usual?
And point to https://www.unicode.org/terms_of_use.html like we do elsewhere?
There was a problem hiding this comment.
I'm not sure about 'elsewhere' or 'as usual' but I'm using the updated approved language, matching several other projects that @annebright has approved:
There was a problem hiding this comment.
terms_of_use.html is a redirect, I don't think it's used in updated notices.
There was a problem hiding this comment.
It's just a bit different from when we worked with Anne to revamp the copyright headers in the data files. 🤷
There was a problem hiding this comment.
It is different from the data files… but, this isn't a data file.
|
|
||
| ----- | ||
|
|
||
| © 2001-2025 Unicode, Inc. Unicode and the Unicode Logo are registered trademarks of Unicode, Inc. in the U.S. and other countries. See [Terms of Use](https://www.unicode.org/copyright.html). |
|
@markusicu any remaining concerns on this one? |
I am a bit confused about how we ended up with different wording in different places, but I am not going to block this PR. (Otherwise I would have "requested changes".) |
Have to ask @annebright |
| @@ -23,7 +27,7 @@ The tools maintainers use GH issues for issues with the code in this repo. | |||
|
|
|||
| ### Copyright & Licenses | |||
|
|
|||
| Copyright © 2001-2024 Unicode, Inc. Unicode and the Unicode Logo are registered trademarks of Unicode, Inc. in the United States and other countries. | |||
| Copyright © 2001-2025 Unicode, Inc. Unicode and the Unicode Logo are registered trademarks of Unicode, Inc. in the United States and other countries. | |||
There was a problem hiding this comment.
Should this be 1996? The files in this repository are full of copyright notices dating back to that year: https://github.com/search?q=repo%3Aunicode-org%2Funicodetools+1996&type=code.
There was a problem hiding this comment.
You mean the start date? That's from the setup spreadsheet.
There was a problem hiding this comment.
If the repo contains content dating back to 1996 then we should change the start date to 1996. I can change it in the master repo spreadsheet. As background, I identified the start date for each repo based primarily on the repo's contribution record, i.e., going back to the first contribution, and used that as the start date unless I had deeper knowledge of the history of the repo's contents. So, it was best guess and some of the start dates in the spreadsheet may be later than they should be. If we are or become aware that a repo has contents that predates the start date in the spreadsheet, then it should be corrected. (See guidelines in the spreadsheet for copyright notice standard language.) In any event, this repo's copyright notice can be changed to have a start date of 1996.
There was a problem hiding this comment.
If the repo contains content dating back to 1996
In fact, it contains content (data files, though perhaps not code) dating back to at least 1994: https://github.com/unicode-org/unicodetools/blob/main/unicodetools/data/ucd/1.1.0-Update/CJKXREF.txt.
And since it contains the entire history of the UCD, it would contain files from 1992 if we could find the floppies they are on. (We do have a data file corresponding to Unicode 1.0.0 as published in 1991, but it is a 2004 reconstruction rather than an actual file from 1991.)
There was a problem hiding this comment.
Ok then let's change it to 1994. I have changed it in the repo spreadsheet.
Fixes: #1015