Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Address feedback on character.jsp from the public mailing list #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 19, 2025
Merged

Address feedback on character.jsp from the public mailing list #1153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2e20b58
character.jsp
eggrobin May 16, 2025
d17e067
Make it work
eggrobin May 16, 2025
95852b2
No `toList()` for old `Stream`
eggrobin May 16, 2025
083770e
Make the tests compile
eggrobin May 16, 2025
1938e8e
exemplars are miscellaneous, not string-valued
eggrobin May 19, 2025
f1c5a00
Fix bidiref which still wanted -Update and bump it to 16
eggrobin May 19, 2025
d93f8c8
Another thing that was stuck at 14
eggrobin May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion UnicodeJsps/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ FROM alpine as cbuild
WORKDIR /build
RUN apk add --update wget make gcc musl-dev
ARG CPATH=https://www.unicode.org/Public/PROGRAMS/BidiReferenceC/
ARG CVERSION=15.1.0
# FIX_FOR_NEW_VERSION
ARG CVERSION=16.0.0
RUN wget -np -nv --reject-regex='.*\.(lib|exe)$' --cut-dirs=4 -nH -r ${CPATH}${CVERSION}/
RUN cd source && gcc -I ../include/ -static -Os -o3 -o bidiref1 bidiref1.c brutils.c brtest.c brtable.c brrule.c
RUN ls -lh /build/source/bidiref1 && (/build/source/bidiref1 || true)
Expand Down
6 changes: 5 additions & 1 deletion UnicodeJsps/src/main/java/org/unicode/jsp/UBAVersion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ public class UBAVersion {
Age_Values.V11_0,
Age_Values.V12_0,
Age_Values.V13_0,
Age_Values.V14_0
Age_Values.V14_0,
Age_Values.V15_0,
Age_Values.V15_1,
Age_Values.V16_0
// FIX_FOR_NEW_VERSION
/* Current version is always last */
);

Expand Down
24 changes: 21 additions & 3 deletions UnicodeJsps/src/main/java/org/unicode/jsp/UnicodeJsp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import java.io.IOException;
import java.io.PrintWriter;
import java.io.StringWriter;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.List;
Expand Down Expand Up @@ -131,8 +132,15 @@ else if (choice.equals("Sentence"))

public static void showProperties(
int cp, String history, boolean showDevProperties, Appendable out) throws IOException {
List<String> originalParameters = new ArrayList<>();
if (!history.isEmpty()) {
originalParameters.add("history=" + history);
}
if (showDevProperties) {
originalParameters.add("showDevProperties=1");
}
showDevProperties = Settings.latestVersionPhase == ReleasePhase.BETA || showDevProperties;
UnicodeUtilities.showProperties(cp, history, showDevProperties, out);
UnicodeUtilities.showProperties(cp, history, showDevProperties, originalParameters, out);
}

static String defaultIdnaInput =
Expand Down Expand Up @@ -201,10 +209,18 @@ public static void showSet(
boolean collate,
Appendable out)
throws IOException {
List<String> originalParameters =
showDevProperties ? List.of("showDevProperties=1") : List.of();
showDevProperties = Settings.latestVersionPhase == ReleasePhase.BETA || showDevProperties;
CodePointShower codePointShower =
new CodePointShower(
grouping, info, showDevProperties, abbreviate, ucdFormat, collate);
grouping,
info,
showDevProperties,
abbreviate,
ucdFormat,
collate,
originalParameters);
UnicodeUtilities.showSetMain(a, showDevProperties, codePointShower, out);
}

Expand Down Expand Up @@ -416,8 +432,10 @@ public static String testIdnaLines(String lines, String filter) {
}

public static String getIdentifier(String script, boolean showDevProperties) {
List<String> originalParameters =
showDevProperties ? List.of("showDevProperties=1") : List.of();
showDevProperties = Settings.latestVersionPhase == ReleasePhase.BETA || showDevProperties;
return UnicodeUtilities.getIdentifier(script, showDevProperties);
return UnicodeUtilities.getIdentifier(script, showDevProperties, originalParameters);
}

static final String VERSIONS =
Expand Down
Loading