Thanks to visit codestin.com
Credit goes to github.com

Skip to content

176-C26 Add Indic_Conjunct_Break #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 9, 2023
Merged

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Aug 8, 2023

[176-C26] Consensus: Add a new informative derived enumerated property Indic_Conjunct_Break (InCB) to DerivedCoreProperties.txt, with values Linker, Consonant, and Extend that correspond respectively to the macros ConjunctLinker, LinkingConsonant, and ExtCccZwj from draft 2 of the the Proposed Update to Unicode Standard Annex #‌29, Unicode Text Segmentation, and with a default value of None (None), for Unicode Version 15.1.

[176-A87] Action Item for Robin Leroy, PAG: Add the new enumerated property Indic_Conjunct_Break (InCB), with values Linker, Consonant, and Extend to PropertyAliases.txt, PropertyValueAliases.txt, and DerivedCoreProperties.txt, for Unicode Version 15.1. See document L2/23-160 item 4.3.

Plus the unicodetools side of

[176-A88] Action Item for Josh Hadley, PAG: Update rule GB9c Unicode Standard Annex #‌29, Unicode Text Segmentation, to use the Indic_Conjunct_Break property instead of macros, for Unicode Version 15.1. See document L2/23-160 item 4.3.


Notes:

  1. The property definitions are as amended in discussion and as written by Ken into the working draft of UAX44.
  2. The tests are generated by setting ExtCccZwj to the union of InCB=Extend and InCB=Linker, as discussed.
  3. There is a new test case for consonant-virama-virama-consonant at the bottom of GraphemeBreakTest; if we replaced ExtCccZwj by InCB=Extend, the behaviour would change for that test, see eggrobin@cb57b44.

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tnx!

Co-authored-by: Markus Scherer <[email protected]>
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tnx pse squash-and-merge

@eggrobin eggrobin merged commit 2aef38e into unicode-org:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants