Change file download urls to pull from https #24

mrluc · 2021-11-21T22:08:14Z

I was reading this over to understand how rust uses the unicode data files, and how rust handles these sort of unicode security issues, and I noticed that when it downloads the source files, the urls it's curling aren't https:

unicode-security/scripts/unicode.py

Lines 46 to 64 in f42826a

    
           # Download a Unicode security table file 
        
           def fetch(f): 
        
               if not os.path.exists(os.path.basename(f)): 
        
                   os.system("curl -O http://www.unicode.org/Public/security/%s/%s" 
        
                             % (UNICODE_VERSION_NUMBER, f)) 
        
               if not os.path.exists(os.path.basename(f)): 
        
                   sys.stderr.write("cannot load %s\n" % f) 
        
                   exit(1) 
        
           # Download a UCD table file 
        
           def fetch_unidata(f): 
        
               if not os.path.exists(os.path.basename(f)): 
        
                   os.system("curl -O http://www.unicode.org/Public/%s/ucd/%s" 
        
                             % (UNICODE_VERSION_NUMBER, f)) 
        
               if not os.path.exists(os.path.basename(f)): 
        
                   sys.stderr.write("cannot load %s" % f) 
        
                   exit(1)

Of course this is in a script that runs pre-commit, and for that + likely many other reasons that I'm ignorant of, this PR may not be needed.

Btw thanks for all you're doing in this repo/crate. This code + its comments are the only thing that's helping me see how one can go from 'tc39 provided files' to 'prevent/warn of naughtiness in source code'. 🙏

http -> https 2x in py script

7f7b26e

Manishearth approved these changes Nov 21, 2021

View reviewed changes

mrluc mentioned this pull request Nov 22, 2021

Fix one instance of non-https curl unicode-rs/unicode-script#12

Merged

Manishearth merged commit 1a8846e into unicode-rs:master Nov 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Change file download urls to pull from https #24

Change file download urls to pull from https #24

Uh oh!

mrluc commented Nov 21, 2021

Uh oh!

Uh oh!

	# Download a Unicode security table file
	def fetch(f):
	if not os.path.exists(os.path.basename(f)):
	os.system("curl -O http://www.unicode.org/Public/security/%s/%s"
	% (UNICODE_VERSION_NUMBER, f))

	if not os.path.exists(os.path.basename(f)):
	sys.stderr.write("cannot load %s\n" % f)
	exit(1)

	# Download a UCD table file
	def fetch_unidata(f):
	if not os.path.exists(os.path.basename(f)):
	os.system("curl -O http://www.unicode.org/Public/%s/ucd/%s"
	% (UNICODE_VERSION_NUMBER, f))

	if not os.path.exists(os.path.basename(f)):
	sys.stderr.write("cannot load %s" % f)
	exit(1)

Change file download urls to pull from https #24

Change file download urls to pull from https #24

Uh oh!

Conversation

mrluc commented Nov 21, 2021

Uh oh!

Uh oh!