Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve CI, (almost) enforce MSRV #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 12, 2025
Merged

Improve CI, (almost) enforce MSRV #47

merged 8 commits into from
Sep 12, 2025

Conversation

Marcondiro
Copy link
Contributor

@Marcondiro Marcondiro commented Sep 12, 2025 •
edited
Loading

This brings several improvements to the CI:

  • Test MSRV
  • Test Windows
  • Replace deprecated actions

Also make the tests compatible with MSRV.
The usage of MSRV still requires to exclude the criterion dev-dependency used for benchmarks.

@Marcondiro
Improve CI stealing unicode-normalization's CI
e4f8b13 
This brings several improvements:
- Test MSRV
- Test Windows
- Replace deprecated actions
@Marcondiro Marcondiro force-pushed the master branch 2 times, most recently from db91578 to de8685a Compare September 12, 2025 08:19
@Marcondiro Marcondiro force-pushed the master branch 3 times, most recently from 5ea5146 to b77150b Compare September 12, 2025 09:24
@Marcondiro Marcondiro force-pushed the master branch 9 times, most recently from ceffbd5 to 8c21347 Compare September 12, 2025 15:33
@Marcondiro Marcondiro changed the title Improve CI by stealing unicode-normalization's CI Improve CI, (almost) enforce MSRV Sep 12, 2025
@Marcondiro Marcondiro marked this pull request as ready for review September 12, 2025 16:02
Manishearth
Manishearth approved these changes Sep 12, 2025
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically the devdeps issue is fixed by cargo update -p, but we have an old MSRV so maybe not here.

@Manishearth Manishearth merged commit 0aeadac into unicode-rs:master Sep 12, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marcondiro @Manishearth