python: Support CPUID hooks #1618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot, I also needed this recently from python and had to manually modify the package... |
|
Hello, thanks for your PR. Note the target branch should be the dev branch and you miss the python annotations. |
|
I've made the changes @wtdcode . Let me know if there's anything else blocking this PR for merging. |
wtdcode
reviewed
May 17, 2022
| @@ -817,6 +824,8 @@ def hook_add(self, htype: int, callback: UC_HOOK_CALLBACK_TYPE , user_data: Any= | |||
| cb = ctypes.cast(UC_HOOK_INSN_OUT_CB(self._hook_insn_out_cb), UC_HOOK_INSN_OUT_CB) | |||
| if arg1 in (x86_const.UC_X86_INS_SYSCALL, x86_const.UC_X86_INS_SYSENTER): # SYSCALL/SYSENTER instruction | |||
| cb = ctypes.cast(UC_HOOK_INSN_SYSCALL_CB(self._hook_insn_syscall_cb), UC_HOOK_INSN_SYSCALL_CB) | |||
| if arg1 == x86_const.UC_X86_INS_CPUID: # CPUID instruction | |||
There was a problem hiding this comment.
See UC_HOOK_CALLBACK_TYPE and add this hook to the possible callback types.
|
Merged and welcome! ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality seems to be missing for the Python bindings when it was added in these commits 9d8a309 7bb7562
Not sure if there's anything else that's missing (or incorrect) for the bindings, but this works for me. I mostly followed the pattern of the other callbacks.