Update RH850 code in staging #2156
Open
+1,324
−3,094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've had a quick look at the changes and it seems OK (but I'm not a unicorn engine expert). Maybe I should try this version with some piece of code I have to see if it still works as expected, but for now I don't have access to this code and won't be able to test it before a few days. Regarding the naming, yes RH850 uses a V850e3v5 CPU and renaming it to V850 seems the best option (but as a consequence, every reference to rh850 in the code need to be renamed as well, how tedious). Originally, I've worked on this implementation in the context of emulating a RH850 SoC thus explaining the name (my mistake). |
|
Renaming usually is the easiest part doing the port =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the RH850 code in the staging branch - it's effectively my way of saying "I've reviewed the code", but there were a lot of changes to be made, so I decided make those changes, since #1918 is a bit old and I didn't want to burden the author with dozens of comments :^).
The main highlights are:
tcg_ctxfor all register manipulation, rather than static variables@virtualabs if you have the time, it'd be great if you can take a look at these changes. If they look good to you, I'd consider RH850 ready. One question I had though is, why name it RH850 and not V850? From the little searching I did online, the RH850 cores are the same as the V850e3v5, so it'd make more sense to name this "V850" as that's the architecture, and then RH850/V850e3v5 is one cpu "model" that can be implemented (then, in theory, we could also support emulating v850e1/e2 chips as well).