Add marathon service labels to Consul KV - #7
Merged
Merged
Conversation
Contributor
Author
|
Not ready for review yet. |
Contributor
Author
|
@miltontony & @Rizziepit ready for review. |
There was a problem hiding this comment.
shouldn't this be in a key call foo instead of data?
Contributor
Author
There was a problem hiding this comment.
Yeah foo is the key, it's in the 'path' I'm checking the line above.
The consul_request dict here is the mocked call to Consul, data here is the payload being sent in the HTTP request, which in this case is bar.
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.