feat: add node-sqlite3 connector
#147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mind to update tests as well? Also considering their similarities, I would keep both under same page 2 sections for alternatives (we could also do a small compare) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
=======================================
Coverage ? 41.18%
=======================================
Files ? 22
Lines ? 828
Branches ? 83
=======================================
Hits ? 341
Misses ? 481
Partials ? 6 ☔ View full report in Codecov by Sentry. |
|
I'm not sure about the compare section. Can you take care of it? 🙏 |
node-sqlite3 connectornode-sqlite3 connector
pi0
approved these changes
Jan 24, 2025
|
(tests are good, CI is buggy with npm rate limits) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a new connector for the
node-sqlite3package.Discussed in nuxt/content#3032 (comment)
I renamed
docs/2.connectors/sqlite.mdtodocs/2.connectors/better-sqlite3.mdin order to create another file for the new connector. We need to redirect the old path to the new one.