feat: close() & support using syntax
#178
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
=======================================
Coverage ? 56.36%
=======================================
Files ? 22
Lines ? 841
Branches ? 114
=======================================
Hits ? 474
Misses ? 365
Partials ? 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can you please ask a test for close? (should be last) |
|
Added a test :) |
pi0
reviewed
Sep 19, 2025
pi0
reviewed
Sep 19, 2025
|
Additionally, i think it would be nice to flag disposed instances so they won't be reused anymore. Also we should reject any new query or prepares when drivers are disposed. (it can be added in abstract wrapper with a |
|
Is the abstract wrapper database.ts or are you suggesting creating a new one? |
|
yes, database.ts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usingsyntax requires Node.js v22 and aboveAdds
usingsupport to automatically close the database connection