feat: add defuSchema
#104
Open
feat: add defuSchema
#104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@pi0 Can I get a review in this please? |
pi0
reviewed
Oct 24, 2023
Author
|
@pi0 Can I get a re-review of this please? Would be realy useful to have this upstream already 😅 |
pi0
reviewed
Nov 8, 2023
pi0
reviewed
Nov 8, 2023
pi0
approved these changes
Nov 8, 2023
Member
pi0
left a comment
There was a problem hiding this comment.
Thanks! (i will try to merge and release by this week)
Member
|
Once last thing, it is missing in https://github.com/unjs/defu/blob/main/lib/defu.cjs |
Author
|
@pi0 Done! |
Author
|
@pi0 Hey sorry for pinging again about this... But it would be really useful to have this upstream! |
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Author
Comment on lines
+137
to
+145
| console.log( | ||
| defuSchema( | ||
| { a: 1, b: 2, c: 3, d: 4 }, | ||
| { a: 2, c: 4, d: 6, e: 8 } | ||
| ) | ||
| ); | ||
| // => { a: 1, c: 3, d: 4, e: 8 } | ||
| `` | ||
|
|
There was a problem hiding this comment.
defuSchema(
{ a: 1, b: 2, c: 3, d: 4 },
{ a: 2, c: 4, d: 6, e: 8 }
)
// => { a: 2, b: 2, c:4, d: 6 }You can check the issua that is opened, the output should be like this. It is useful to review your code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Fixes #48
❓ Type of change
📚 Description
defuSchemafor removing keys not present in the default object📝 Checklist