Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(interop): passthrough module if it is a promise #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2025
Merged

fix(interop): passthrough module if it is a promise #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
738f465
fix(interop): passthrough module if it is a promise
pi0 Jul 24, 2025
8b8b742
fix ts issue
pi0 Jul 24, 2025
fd97200
update snapshot
pi0 Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@ function interopDefault(mod: any): any {
const defIsNil = def === null || def === undefined;
const defIsObj = defType === "object" || defType === "function";

if (defIsNil && mod instanceof Promise) {
// Hotfix for #388
return mod;
}

return new Proxy(mod, {
get(target, prop, receiver) {
if (prop === "__esModule") {
Expand Down
3 changes: 2 additions & 1 deletion test/__snapshots__/fixtures.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,5 +127,6 @@ Decorator called with 1 arguments.
normalizeUserEntity: [Function: normalizeUserEntity]
}
}
child"
child
promise resolved"
`;
1 change: 1 addition & 0 deletions test/fixtures.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ describe("fixtures", async () => {
)
.replace("internal/errors:496", "events:276")
.replace(" ^", " ^")
.replace(/ExperimentalWarning: CommonJS module/, "")
// eslint-disable-next-line no-control-regex
.replace(/\u001B\[[\d;]*m/gu, "")
.trim()
Expand Down
2 changes: 2 additions & 0 deletions test/fixtures/typescript/def-promise.cts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
// https://github.com/unjs/jiti/issues/388
export = Promise.resolve("promise resolved");
3 changes: 3 additions & 0 deletions test/fixtures/typescript/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,12 @@ import test, { type FeedService as _FeedService } from "./test";
import Clazz from "./decorators";
import { test as satisfiesTest } from "./satisfies";
import { child } from "./parent.mjs";
// @ts-expect-error (needs allowImportingTsExtensions)
import defPromise from "./def-promise.cts";

export type { Test } from "./types";

console.log(test(), Clazz);
console.log(satisfiesTest());
console.log(child());
console.log(await defPromise);