Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(findExportNames): do not require space before named exports #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2024
Merged

fix(findExportNames): do not require space before named exports #285

merged 2 commits into from
Nov 12, 2024

Conversation

danielroe
Copy link
Member

previously we required a space export { but commonly minifiers omit it: export{

@danielroe danielroe requested review from pi0 and Copilot November 11, 2024 23:54
Copilot
Copilot AI reviewed Nov 11, 2024
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.

@pi0 pi0 changed the title fix: do not require space before named exports fix(findExportNames): do not require space before named exports Nov 12, 2024
@pi0 pi0 merged commit 2af0152 into main Nov 12, 2024
4 checks passed
@danielroe danielroe deleted the fix/minified-exports branch November 12, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0