Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: respect directory separator when matching entries#214

Merged
danielroe merged 4 commits into
unjs:mainfrom
Bernankez:main
Apr 15, 2023
Merged

fix: respect directory separator when matching entries#214
danielroe merged 4 commits into
unjs:mainfrom
Bernankez:main

Conversation

@Bernankez
Copy link
Copy Markdown

fix #213

@Bernankez
Copy link
Copy Markdown
Author

I'm not sure if it's the right way to fix it.

@pi0 pi0 requested a review from danielroe March 27, 2023 10:29
Comment thread src/auto.ts Outdated
Comment thread src/auto.ts Outdated
Copy link
Copy Markdown
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot! ❤️ I think we likely also want to include files not prefixed with / (in case they are at root level), but that is a minor change.

pi0 and others added 2 commits March 28, 2023 11:16
Co-authored-by: Daniel Roe <[email protected]>
Co-authored-by: Daniel Roe <[email protected]>
@pi0 pi0 requested a review from danielroe March 28, 2023 09:16
@danielroe danielroe changed the title fix: match similar files when inferring entry (#213) fix: respect directory separator when matching entries Apr 15, 2023
@danielroe danielroe merged commit 5df5058 into unjs:main Apr 15, 2023
@pi0 pi0 mentioned this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect inferred entries from package.json

3 participants