Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(solid-js): correct peerDependency version#671

Merged
harlan-zw merged 1 commit intounjs:mainfrom
tyeporter:fix/solid-js-peer-dep-typo
Mar 2, 2026
Merged

fix(solid-js): correct peerDependency version#671
harlan-zw merged 1 commit intounjs:mainfrom
tyeporter:fix/solid-js-peer-dep-typo

Conversation

@tyeporter
Copy link
Contributor

@tyeporter tyeporter commented Mar 1, 2026 •
edited by coderabbitai bot
Loading

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Fixes intended minimum compatible release for solid-js. npm i @unhead/solid-js@next now passes without ERESOLVE error.

Summary by CodeRabbit

  • Chores
    • Updated version constraints for a core framework dependency, expanding compatibility to support a wider range of earlier versions and enabling installation in more environments.

@tyeporter
fix(solid-js): correct peerDependency version
c335df5 
Fixes the version range to reflect the intended minimum compatible release and prevents package resolution issues.
@coderabbitai
Copy link

coderabbitai bot commented Mar 1, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 09e8e80 and c335df5.

📒 Files selected for processing (1)
  • packages/solid-js/package.json
📝 Walkthrough

Walkthrough

The peer dependency constraint for solid-js in the @unhead/solid-js package is updated from ">=19" to ">=1.9.0", changing the minimum required major version from version 19 to version 1.9.0.

Changes

Cohort / File(s) Summary
Peer Dependency Update
packages/solid-js/package.json		 Updated solid-js peer dependency constraint from ">=19" to ">=1.9.0", lowering the minimum version requirement.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A nimble hop through version land,
Where constraints shift like desert sand,
Nineteen down to one-point-nine,
The solid ground will still align,
Compatibility takes a gentle stand! 🌟

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: correcting the peerDependency version for solid-js from an incorrect constraint to the intended one.
Description check ✅ Passed The description includes the required type of change checkboxes and explains the problem solved, though the linked issue section is empty.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@harlan-zw
Copy link
Collaborator

harlan-zw commented Mar 2, 2026

Thanks for this :)

@harlan-zw harlan-zw merged commit 64e179a into unjs:main Mar 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tyeporter @harlan-zw