fix: type render() return across all framework integrations#672
Merged
fix: type render() return across all framework integrations#672
Conversation
VueHeadClient only forwarded the Input generic to Unhead, leaving RenderResult at its default of unknown. This caused head.render() to return unknown instead of SSRHeadPayload (server) or boolean (client).
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…orks Apply the same RenderResult fix to React, Svelte, and Solid client createHead functions using ClientUnhead. Also type BaseStreamableHeadContext with ServerUnhead so streaming render() calls no longer need SSRHeadPayload casts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
N/A — reported by @danielroe as a downstream regression (
head.render()returnsunknown)❓ Type of change
📚 Description
Unhead<Input, RenderResult>has two generics but framework integrations only forwardedInput, leavingRenderResultat its default ofunknown. This causedhead.render()to returnunknowninstead ofSSRHeadPayload(server) orboolean(client).Vue: Added second generic to
VueHeadClient<I, R>and threaded it through server/clientcreateHeadreturn types. Added type test withsatisfiesassertions.React, Svelte, Solid: Changed client
createHeadreturn type fromUnheadtoClientUnhead(which extendsUnhead<T, boolean>).Streaming: Typed
BaseStreamableHeadContext.headasServerUnhead<T>instead ofUnhead<T>, removing unnecessaryas SSRHeadPayloadcasts in Svelte and Solid streaming code.