fix(schema-org): dedupe typed arrays by @type during node merge#702
Merged
Conversation
When two components define Product with different offers.availability values, the merge function was concatenating the offers arrays instead of letting the later definition win. Now arrays of typed schema.org objects are deduped by @type, matching the existing potentialAction behavior. Closes harlan-zw/nuxt-schema-org#94
Contributor
Bundle Size Analysis
|
📝 WalkthroughWalkthroughThis change fixes a merging conflict in schema.org object handling by implementing deduplication logic for arrays of typed objects. When merging multiple schema.org objects with the same Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves harlan-zw/nuxt-schema-org#94
❓ Type of change
📚 Description
When two schema-org entries share the same
@id(e.g. twoProductnodes from different components), themerge()function deep-merged their nested objects. For arrays of typed schema objects likeoffers, this caused conflicting scalar values (e.g.availability: InStockvsOutOfStock) to both be retained instead of the later definition winning.Extends the existing
@typededuplication logic (previously only applied topotentialAction) to all arrays of typed schema objects. When merging arrays where every element has a@typeproperty, later definitions now override earlier ones by type.