-
Notifications
You must be signed in to change notification settings - Fork 167
feat(azure-storage-blob): native maxDepth
support
#553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
==========================================
- Coverage 59.99% 58.78% -1.22%
==========================================
Files 42 42
Lines 3657 3809 +152
Branches 590 600 +10
==========================================
+ Hits 2194 2239 +45
- Misses 1460 1567 +107
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maxDepth
support
@pi0 do you know why we disabled these tests? when I run them locally, they seem to work fairly well if teardown happens cleanly |
IIRC tests were super flakey some point in CI. (sorry for delay, trying to find some time to review. might delay this PR) |
No rush at all. We can keep these tests disabled for now if you like They do pass locally at least |
@pi0 what do you think about merging this one? 👀 |
Still have to check better. Really no ETA sorry, i appreciate if you stay patient 🙏🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ (i trust you have done proper end-to end testing)
@43081j can you please check merge conflict? |
Implements native `maxDepth` for the `azure-storage-blob` driver by using hierarchical fetches.
should be caught up now 👍 |
Implements native
maxDepth
for theazure-storage-blob
driver by using hierarchical fetches.the tests are skipped for whatever reason, but I ran them locally and they pass