Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

43081j
Copy link
Member

@43081j 43081j commented Dec 29, 2024

Implements native maxDepth for the azure-storage-blob driver by using hierarchical fetches.

the tests are skipped for whatever reason, but I ran them locally and they pass

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 9.75610% with 37 lines in your changes missing coverage. Please review.

Project coverage is 58.78%. Comparing base (70310f9) to head (8b8334a).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
src/drivers/azure-storage-blob.ts 9.75% 37 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
- Coverage   59.99%   58.78%   -1.22%     
==========================================
  Files          42       42              
  Lines        3657     3809     +152     
  Branches      590      600      +10     
==========================================
+ Hits         2194     2239      +45     
- Misses       1460     1567     +107     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pi0 pi0 changed the title feat: implement maxDepth for azure-storage-blob feat(azure-storage-blob): native maxDepth support Jan 3, 2025
@43081j
Copy link
Member Author

43081j commented Jan 6, 2025

@pi0 do you know why we disabled these tests?

when I run them locally, they seem to work fairly well if teardown happens cleanly

@pi0
Copy link
Member

pi0 commented Jan 7, 2025

IIRC tests were super flakey some point in CI.

(sorry for delay, trying to find some time to review. might delay this PR)

@43081j
Copy link
Member Author

43081j commented Jan 7, 2025

No rush at all. We can keep these tests disabled for now if you like

They do pass locally at least

@43081j
Copy link
Member Author

43081j commented Jan 21, 2025

@pi0 what do you think about merging this one? 👀

@pi0
Copy link
Member

pi0 commented Jan 21, 2025

Still have to check better. Really no ETA sorry, i appreciate if you stay patient 🙏🏼

@pi0 pi0 self-requested a review as a code owner February 21, 2025 13:54
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ (i trust you have done proper end-to end testing)

@pi0
Copy link
Member

pi0 commented Apr 27, 2025

@43081j can you please check merge conflict?

Implements native `maxDepth` for the `azure-storage-blob` driver by
using hierarchical fetches.
@43081j
Copy link
Member Author

43081j commented Apr 27, 2025

should be caught up now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants