fix(ci): upgrade Node past CJS lexer crash - #7061
Merged
Merged
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
chronark
requested review from
a team,
Flo4604,
MichaelUnkey,
mcstepp and
ogzhanolguncu
and removed request for
a team
August 19, 2026 07:17
chronark
marked this pull request as ready for review
August 19, 2026 07:17
chronark
enabled auto-merge
August 19, 2026 07:17
ogzhanolguncu
approved these changes
Aug 19, 2026
perkinsjr
approved these changes
Aug 19, 2026
|
💬 Slack discussion for this PR: https://slack.com/app_redirect?channel=C0BR6J7U9FU&team=T05T2KX8C3X |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our CI failed a few times and it looks like that's a bug in the node version we were using. Upgrading to the latest LTS should fix it.
AI SLOP BELOW
Summary
Evidence
The CI abort signature,
v8::ToLocalChecked Empty MaybeLocalinnode::cjs_lexer::Parse, matches nodejs/node#63323. The regression affects Node 24.14.0 and newer after the native CJS lexer replaced the prior WASM implementation.Observed CI failures:
@unkey/rbac#teston3caf1b02: failed GitHub check and Depot attempt. All 39 RBAC tests passed before Node aborted; the identical-SHA retry succeeded.@unkey/dashboard#teston merge SHA3c02acd2: failed GitHub check and Depot attempt. All 755 dashboard tests passed before the same Node abort.Node fixed the unchecked
MaybeLocalpath in nodejs/node#63885, followed by nodejs/node#63943. Node 24.16.0 predates those fixes, and the 24.17/24.18 changelogs do not include them. Node 24.19.0 is the first 24.x release whose changelog contains both backports, so aligning CI on 24.16.0 would retain the crash.Validation
MISE_LOCKED=1 mise install nodeinstalled Node v24.19.0 from the regenerated lockfileCI=1 mise exec -- pnpm --dir=web turbo run test --filter=@unkey/rbac --filter=@unkey/dashboardpassedgit diff --checkpassedThe failure is probabilistic, so repeated passing runs cannot prove absence, but Node 24.19.0 removes the exact upstream fatal path.