Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

blahkheart
Copy link
Contributor

Description

This proposal is a template for making proposals that swap ETH to USDC using Uniswap V3 and make a transfer of a specific amount of USDC to a specified address. This was created to facilitate the funding of Unlock DAO's partnership with Rise Up Morning Show.

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Sep 6, 2025
Copy link

vercel bot commented Sep 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
unlock-airdrops Ignored Ignored Preview Sep 6, 2025 3:24am
unlock-storybook Ignored Ignored Preview Sep 6, 2025 3:24am

@blahkheart
Copy link
Contributor Author

@clemsos @julien51 @0xTxbi Please review

Copy link
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @blahkheart The code looks good but I am worried that the proposal may fail because the ETH/USDC price will evolve over the days that the proposal is "in progress".
Does it make sense?

I think the only way to go thru here is to specify either an USDC amount we need (probably better) or a ETH amount we want to spend, but we can have fixed values for both

@blahkheart
Copy link
Contributor Author

Yes. That makes a lot of sense! Let me look into this right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants