chore: release v1.11.1 #181
Conversation
7814802 to
0a7bc16
Compare
WalkthroughThis change updates the project version to 1.11.1 across Cargo.toml, package.json, and the changelog. The changelog documents a documentation update that introduces the missing Changes
Possibly related PRs
Suggested labels
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 7814802 in 39 seconds. Click for details.
- Reviewed
52lines of code in3files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Cargo.toml:18
- Draft comment:
Workspace dependency version bumped to 1.11.1; update appears consistent. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. Cargo.toml:21
- Draft comment:
The [package] section version is updated to 1.11.1 and is consistent with the workspace settings. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. Cargo.lock:1115
- Draft comment:
Cargo.lock correctly reflects the update of unrs_resolver to version 1.11.1. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_w70rapjt0PCCFsc1
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
=======================================
Coverage 95.10% 95.10%
=======================================
Files 12 12
Lines 2818 2818
=======================================
Hits 2680 2680
Misses 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
14-18: Unify list-marker style to silence markdownlint (MD004).Line 14 uses
-while line 18 switches to*. Stick to one marker (the project mostly uses dashes) to avoid linter noise.-* @JounQin +- @JounQin
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
CHANGELOG.md(1 hunks)Cargo.toml(1 hunks)package.json(2 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: JounQin
PR: unrs/unrs-resolver#72
File: fixtures/tsconfig/cases/dot-alias/tsconfigs/tsconfig.base.json:0-0
Timestamp: 2025-04-21T06:11:46.964Z
Learning: JounQin's fix for the dot alias issue in PR #72 addresses the problem by correctly normalizing paths in the `extend_tsconfig` method, ensuring that base URLs are properly resolved as absolute paths when extending tsconfigs, rather than adding special case handling for dot aliases in the resolver.
CHANGELOG.md (1)
Learnt from: JounQin
PR: unrs/unrs-resolver#75
File: src/tests/pnp.rs:116-133
Timestamp: 2025-04-21T08:17:34.175Z
Learning: Test cases in unrs-resolver that intentionally document failing behavior should make the intent clear by either: 1) asserting on the expected error condition rather than the desired behavior, 2) using #[should_panic] for tests expected to panic, or 3) using #[ignore] with a reason to skip known failing tests in CI.
Cargo.toml (5)
Learnt from: JounQin
PR: unrs/unrs-resolver#136
File: src/tests/extension_alias.rs:36-46
Timestamp: 2025-06-05T18:52:30.363Z
Learning: The fixtures/yarn directory in the unrs-resolver project requires running `yarn install` to install TypeScript dependencies before tests can run, similar to other fixture directories like fixtures/pnp. The test in src/tests/extension_alias.rs depends on the installed TypeScript package providing lib/typescript.d.ts and related files.
Learnt from: JounQin
PR: unrs/unrs-resolver#136
File: src/tests/extension_alias.rs:36-46
Timestamp: 2025-06-05T18:52:30.363Z
Learning: The fixtures/yarn directory in the unrs-resolver project requires running `yarn install` to install TypeScript dependencies before tests can run, similar to other fixture directories like fixtures/pnp. The test in src/tests/extension_alias.rs depends on the installed TypeScript package providing lib/typescript.d.ts and related files.
Learnt from: JounQin
PR: unrs/unrs-resolver#40
File: src/tests/resolve.rs:121-136
Timestamp: 2025-03-29T04:14:03.715Z
Learning: For tests involving npm/yarn package resolution in the unrs-resolver project, dependencies must be installed first using the appropriate package manager commands (pnpm i, yarn) in both the root directory and fixture directories like fixtures/pnp and fixtures/misc/nested-package-json.
Learnt from: JounQin
PR: unrs/unrs-resolver#75
File: src/tests/pnp.rs:116-133
Timestamp: 2025-04-21T09:52:45.840Z
Learning: In Yarn PnP environments, some packages use nested package.json files for subpaths instead of the exports field. The resolver should check for these nested package.json files when resolving subpaths like `@atlaskit/pragmatic-drag-and-drop/combine` to correctly handle packages with this structure.
Learnt from: JounQin
PR: unrs/unrs-resolver#115
File: tests/resolve_test.rs:251-263
Timestamp: 2025-05-28T02:21:41.547Z
Learning: In pnpm workspaces, `pnpm install` must be run first to initialize dependencies and create the proper node_modules/.pnpm structure before tests can pass. Tests that rely on resolving packages will fail if dependencies haven't been installed yet.
package.json (7)
Learnt from: JounQin
PR: unrs/unrs-resolver#40
File: src/tests/resolve.rs:121-136
Timestamp: 2025-03-29T04:14:03.715Z
Learning: For tests involving npm/yarn package resolution in the unrs-resolver project, dependencies must be installed first using the appropriate package manager commands (pnpm i, yarn) in both the root directory and fixture directories like fixtures/pnp and fixtures/misc/nested-package-json.
Learnt from: JounQin
PR: unrs/unrs-resolver#136
File: src/tests/extension_alias.rs:36-46
Timestamp: 2025-06-05T18:52:30.363Z
Learning: The fixtures/yarn directory in the unrs-resolver project requires running `yarn install` to install TypeScript dependencies before tests can run, similar to other fixture directories like fixtures/pnp. The test in src/tests/extension_alias.rs depends on the installed TypeScript package providing lib/typescript.d.ts and related files.
Learnt from: JounQin
PR: unrs/unrs-resolver#75
File: src/tests/pnp.rs:116-133
Timestamp: 2025-04-21T09:52:45.840Z
Learning: In Yarn PnP environments, some packages use nested package.json files for subpaths instead of the exports field. The resolver should check for these nested package.json files when resolving subpaths like `@atlaskit/pragmatic-drag-and-drop/combine` to correctly handle packages with this structure.
Learnt from: JounQin
PR: unrs/unrs-resolver#136
File: src/tests/extension_alias.rs:36-46
Timestamp: 2025-06-05T18:52:30.363Z
Learning: The fixtures/yarn directory in the unrs-resolver project requires running `yarn install` to install TypeScript dependencies before tests can run, similar to other fixture directories like fixtures/pnp. The test in src/tests/extension_alias.rs depends on the installed TypeScript package providing lib/typescript.d.ts and related files.
Learnt from: JounQin
PR: unrs/unrs-resolver#75
File: fixtures/pnp/package.json:11-14
Timestamp: 2025-04-21T08:11:41.469Z
Learning: The project uses a justfile with an `install` task that includes running yarn in the fixtures/pnp directory to install dependencies with the command: `cd fixtures/pnp && yarn`.
Learnt from: JounQin
PR: unrs/unrs-resolver#144
File: napi/patch.mjs:5-5
Timestamp: 2025-06-10T13:53:02.983Z
Learning: Build-time scripts in napi/patch.mjs and similar build pipeline contexts don't require error handling for reading expected files like index.js, as these files are guaranteed to be present during the build process.
Learnt from: JounQin
PR: unrs/unrs-resolver#115
File: tests/resolve_test.rs:251-263
Timestamp: 2025-05-28T02:21:41.547Z
Learning: In pnpm workspaces, `pnpm install` must be run first to initialize dependencies and create the proper node_modules/.pnpm structure before tests can pass. Tests that rely on resolving packages will fail if dependencies haven't been installed yet.
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
18-18: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Upload coverage file
- GitHub Check: Benchmark
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (2)
Cargo.toml (1)
18-20: Version bump looks consistent across workspace & crate.
1.11.1is set both under[workspace.dependencies]and[package]; nothing else required here.Also applies to: 22-24
package.json (1)
3-3: Versions synchronized between Cargo.toml and package.json
✅ Verified: both set to 1.11.1Consider adding a CI check to enforce this going forward:
#!/usr/bin/env bash set -euo pipefail cargo_version=$(grep -m1 -E '^version *= *"' Cargo.toml | sed -E 's/.*"([^"]+)".*/\1/') pkg_version=$(jq -r .version package.json) if [[ "$cargo_version" != "$pkg_version" ]]; then echo "❌ Version mismatch: Cargo.toml=$cargo_version, package.json=$pkg_version" exit 1 fi echo "✅ Versions match: $cargo_version"
- package.json: line 3
- Cargo.toml:
versionfield
CodSpeed Performance ReportMerging #181 will not alter performanceComparing Summary
|
8f98633 to
5e6cf30
Compare
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 5e6cf30 in 40 seconds. Click for details.
- Reviewed
73lines of code in4files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Cargo.toml:23
- Draft comment:
Version updated to 1.11.1. Ensure workspace dependency and package version are in sync. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. package.json:3
- Draft comment:
Version bumped to 1.11.1 and postinstall script updated accordingly. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_DmGzyMpnrIuA9gnE
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
CHANGELOG.md (2)
10-12: Insert a blank line after the version heading
markdownlintflags the missing newline between the## 1.11.1heading and the subsequent### Documentationsub-heading. Adding an empty line keeps the document structure consistent with earlier sections and silences the linter.-## [1.11.1](https://github.com/unrs/unrs-resolver/compare/v1.11.0...v1.11.1) - 2025-07-09 -### <!-- 3 -->📚 Documentation +## [1.11.1](https://github.com/unrs/unrs-resolver/compare/v1.11.0...v1.11.1) - 2025-07-09 + +### <!-- 3 -->📚 Documentation
16-18: Unify bullet style in “Contributors” listsPrevious Contributors sections use the
*bullet while feature/refactor lists use-.
markdownlint(MD004) recommends choosing one style per document. Either:
- Change this line to
- @JounQin, or- Convert earlier contributors bullets to
-.Pick whichever convention you prefer and apply consistently.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
CHANGELOG.md(1 hunks)Cargo.toml(1 hunks)package.json(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- Cargo.toml
🚧 Files skipped from review as they are similar to previous changes (1)
- package.json
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: JounQin
PR: unrs/unrs-resolver#72
File: fixtures/tsconfig/cases/dot-alias/tsconfigs/tsconfig.base.json:0-0
Timestamp: 2025-04-21T06:11:46.964Z
Learning: JounQin's fix for the dot alias issue in PR #72 addresses the problem by correctly normalizing paths in the `extend_tsconfig` method, ensuring that base URLs are properly resolved as absolute paths when extending tsconfigs, rather than adding special case handling for dot aliases in the resolver.
CHANGELOG.md (1)
Learnt from: JounQin
PR: unrs/unrs-resolver#75
File: src/tests/pnp.rs:116-133
Timestamp: 2025-04-21T08:17:34.175Z
Learning: Test cases in unrs-resolver that intentionally document failing behavior should make the intent clear by either: 1) asserting on the expected error condition rather than the desired behavior, 2) using #[should_panic] for tests expected to panic, or 3) using #[ignore] with a reason to skip known failing tests in CI.
🪛 LanguageTool
CHANGELOG.md
[grammar] ~10-~10: Use correct spacing
Context: ...s-resolver/compare/v1.11.0...v1.11.1) - 2025-07-09 ### 📚 Documentation - add missing `descri...
(QB_NEW_EN_OTHER_ERROR_IDS_5)
[grammar] ~12-~12: Use correct spacing
Context: ...v1.11.1) - 2025-07-09 ### 📚 Documentation - add missing descriptionFiles option i...
(QB_NEW_EN_OTHER_ERROR_IDS_5)
[grammar] ~14-~14: There might be a problem here.
Context: ...scriptionFiles` option introduction (by @JounQin) ### Contributors * @JounQin ## [1.11.0](https://github.com/unrs/unrs-re...
(QB_NEW_EN_MERGED_MATCH)
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
18-18: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Lint
- GitHub Check: Test (ubuntu-latest)
- GitHub Check: Test (macos-14)
- GitHub Check: Benchmark
- GitHub Check: Codacy Static Code Analysis
5e6cf30 to
c35c134
Compare
c35c134 to
468a00b
Compare
|
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 468a00b in 56 seconds. Click for details.
- Reviewed
73lines of code in4files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Cargo.toml:22
- Draft comment:
Version bump to 1.11.1 is applied consistently in both workspace deps and package section. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative and does not provide any actionable feedback or suggestions. It simply states that a version bump is applied consistently, which does not require any action from the PR author.
2. package.json:3
- Draft comment:
Package version and postinstall script updated to 1.11.1 correctly. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, stating that a package version and postinstall script were updated correctly. It does not provide any actionable feedback or suggestions for improvement.
Workflow ID: wflow_GKvX3WHBTQc0LvGO
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
14-14: Polish the bullet wording for clarity & consistencyMinor language tweak keeps the tone consistent with previous entries and reads a bit smoother.
- - add missing `descriptionFiles` option introduction (by @JounQin) + - Add missing introduction for the `descriptionFiles` option (by @JounQin)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
CHANGELOG.md(1 hunks)Cargo.toml(1 hunks)package.json(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- Cargo.toml
- package.json
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: JounQin
PR: unrs/unrs-resolver#72
File: fixtures/tsconfig/cases/dot-alias/tsconfigs/tsconfig.base.json:0-0
Timestamp: 2025-04-21T06:11:46.964Z
Learning: JounQin's fix for the dot alias issue in PR #72 addresses the problem by correctly normalizing paths in the `extend_tsconfig` method, ensuring that base URLs are properly resolved as absolute paths when extending tsconfigs, rather than adding special case handling for dot aliases in the resolver.
CHANGELOG.md (1)
Learnt from: JounQin
PR: unrs/unrs-resolver#75
File: src/tests/pnp.rs:116-133
Timestamp: 2025-04-21T08:17:34.175Z
Learning: Test cases in unrs-resolver that intentionally document failing behavior should make the intent clear by either: 1) asserting on the expected error condition rather than the desired behavior, 2) using #[should_panic] for tests expected to panic, or 3) using #[ignore] with a reason to skip known failing tests in CI.
🪛 LanguageTool
CHANGELOG.md
[grammar] ~10-~10: Use correct spacing
Context: ...s-resolver/compare/v1.11.0...v1.11.1) - 2025-07-09 ### 📚 Documentation - add missing `descri...
(QB_NEW_EN_OTHER_ERROR_IDS_5)
[grammar] ~12-~12: Use correct spacing
Context: ...v1.11.1) - 2025-07-09 ### 📚 Documentation - add missing descriptionFiles option i...
(QB_NEW_EN_OTHER_ERROR_IDS_5)
[grammar] ~14-~14: There might be a problem here.
Context: ...scriptionFiles` option introduction (by @JounQin) ### Contributors * @JounQin ## [1.11.0](https://github.com/unrs/unrs-re...
(QB_NEW_EN_MERGED_MATCH)
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
18-18: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Benchmark
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (1)
CHANGELOG.md (1)
10-18: Changelog addition looks correct otherwiseVersion, link target, date, and contributor section all match the release bump. No structural issues detected.
🤖 New release
unrs_resolver: 1.11.0 -> 1.11.1Changelog
This PR was generated with release-plz.
Important
Bump
unrs_resolverversion to 1.11.1 with documentation update fordescriptionFilesoption.unrs_resolverversion from 1.11.0 to 1.11.1 inCargo.toml,Cargo.lock, andpackage.json.descriptionFilesoption introduction inCHANGELOG.md.release-plz.This description was created by
for 468a00b. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit
descriptionFilesoption and crediting the contributor.