fix: disable mimalloc on linux with aarch64 #69

JounQin · 2025-04-20T07:06:05Z

close #64

close import-js/eslint-import-resolver-typescript#406

Important

Disable mimalloc on Linux with aarch64 in napi/src/lib.rs due to allocator issues.

Configuration:
- Disable mimalloc on Linux with aarch64 architecture in napi/src/lib.rs due to allocator issues (see Illegal instruction error - Raspberry PI 4 aarch64 #64).
- Existing exclusions for ARM, FreeBSD, and WASM remain unchanged.

^{This description was created by}^{for 10f555d. You can customize this summary. It will automatically update as commits are pushed.}

Summary by CodeRabbit

Chores
- Updated internal configuration to improve compatibility on certain Linux devices. No visible changes to app features or functionality.

coderabbitai · 2025-04-20T07:06:12Z

Walkthrough

The change updates the global memory allocator configuration in the napi/src/lib.rs file. Specifically, it adds a new conditional exclusion so that the mimalloc_safe::MiMalloc allocator is not used when compiling for the aarch64 architecture on Linux. Previously, this allocator was only excluded for ARM, FreeBSD, and WebAssembly targets. No other code or logic is affected by this change.

Changes

File(s)	Change Summary
napi/src/lib.rs	Updated the conditional compilation attributes to further exclude Linux aarch64 from using the `mimalloc_safe::MiMalloc` global allocator.

Sequence Diagram(s)

sequenceDiagram
    participant Build
    participant AllocatorConfig
    participant MiMalloc

    Build->>AllocatorConfig: Compile napi/src/lib.rs
    AllocatorConfig->>AllocatorConfig: Check target architecture and OS
    alt Not ARM/FreeBSD/WASM/Linux aarch64
        AllocatorConfig->>MiMalloc: Set MiMalloc as global allocator
    else
        AllocatorConfig->>AllocatorConfig: Use default allocator
    end

Assessment against linked issues

Objective	Addressed	Explanation
Prevent illegal instruction error on Raspberry Pi 4 aarch64 by excluding MiMalloc (#64)	✅

Poem

A hop and a skip, a change in the heap,
For aarch64 on Linux, MiMalloc won’t creep.
No more illegal instructions to make you frown,
Raspberry Pi 4 will no longer go down!
With allocators tamed, our code runs free—
A bunny’s delight in compatibility! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cf496e2 and 10f555d.

📒 Files selected for processing (1)

napi/src/lib.rs (1 hunks)

✅ Files skipped from review due to trivial changes (1)

napi/src/lib.rs

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Test (windows-latest)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Copilot

Pull Request Overview

This PR disables mimalloc on Linux with aarch64 to address issues reported in #64.

Updated the conditional compilation attribute in napi/src/lib.rs to exclude Linux aarch64 from using mimalloc.

ellipsis-dev

Important

Looks good to me! 👍

Reviewed everything up to cf496e2 in 30 seconds. Click for details.

Reviewed 15 lines of code in 1 files
Skipped 0 files when reviewing.
Skipped posting 2 draft comments. View those below.
Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. napi/src/lib.rs:5

Draft comment:
Consider adding an inline comment explaining why mimalloc is disabled for Linux AArch64 (e.g., Raspberry PI incompatibility) to aid future maintainability.
Reason this comment was not posted:
Confidence changes required: 33% <= threshold 50% None

2. napi/src/lib.rs:1

Draft comment:
Good fix. Consider adding an inline comment explaining that mimalloc is disabled on Linux aarch64 (per issue Illegal instruction error - Raspberry PI 4 aarch64 #64) to aid future maintainers.
Reason this comment was not posted:
Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_KDUI4jn79C42eJY0

^{You can customize}^{by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8772685 and cf496e2.

📒 Files selected for processing (1)

napi/src/lib.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Test (windows-latest)

napi/src/lib.rs

close #64

sonarqubecloud · 2025-04-20T07:12:54Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ellipsis-dev

Important

Looks good to me! 👍

Reviewed 10f555d in 24 seconds. Click for details.

Reviewed 16 lines of code in 1 files
Skipped 0 files when reviewing.
Skipped posting 2 draft comments. View those below.
Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. napi/src/lib.rs:2

Draft comment:
The cfg condition correctly disables mimalloc on ARM, FreeBSD, WASM, and Linux/aarch64 as intended in Illegal instruction error - Raspberry PI 4 aarch64 #64. No issues detected.
Reason this comment was not posted:
Confidence changes required: 0% <= threshold 50% None

2. napi/src/lib.rs:1

Draft comment:
The new cfg condition correctly disables mimalloc on Linux/aarch64. Ensure tests cover this target.
Reason this comment was not posted:
Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_bUgtT2qvmYKukHts

^{You can customize}^{by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

JounQin requested a review from Copilot April 20, 2025 07:06

Copilot AI reviewed Apr 20, 2025

View reviewed changes

ellipsis-dev bot reviewed Apr 20, 2025

View reviewed changes

coderabbitai bot reviewed Apr 20, 2025

View reviewed changes

napi/src/lib.rs Outdated Show resolved Hide resolved

fix: disable mimalloc on linux with aarch64

10f555d

close #64

JounQin force-pushed the fix/linux_aarch64 branch from cf496e2 to 10f555d Compare April 20, 2025 07:12

ellipsis-dev bot reviewed Apr 20, 2025

View reviewed changes

JounQin merged commit 12dca0c into main Apr 20, 2025
14 checks passed

JounQin deleted the fix/linux_aarch64 branch April 20, 2025 07:19

JounQin mentioned this pull request Apr 20, 2025

Illegal instruction error - Raspberry PI 4 aarch64 purpleprotocol/mimalloc_rust#137

Closed

coderabbitai bot mentioned this pull request Apr 24, 2025

feat: enable no_opt_arch flag for mimalloc-safe on linux-aarch64 #98

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: disable mimalloc on linux with aarch64 #69

fix: disable mimalloc on linux with aarch64 #69

JounQin commented Apr 20, 2025 •

edited

Loading

coderabbitai bot commented Apr 20, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Copilot AI left a comment

ellipsis-dev bot left a comment

coderabbitai bot left a comment

sonarqubecloud bot commented Apr 20, 2025

ellipsis-dev bot left a comment

fix: disable mimalloc on linux with aarch64 #69

fix: disable mimalloc on linux with aarch64 #69

Conversation

JounQin commented Apr 20, 2025 • edited Loading

Summary by CodeRabbit

coderabbitai bot commented Apr 20, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Apr 20, 2025

Quality Gate passed

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

JounQin commented Apr 20, 2025 •

edited

Loading

coderabbitai bot commented Apr 20, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)