Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix double bos #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix double bos #106

wants to merge 1 commit into from

Conversation

tamewild
Copy link

@tamewild tamewild commented Mar 28, 2025 •
edited
Loading

It was mistakenly added here 4a66f8b

image

@Datta0
Copy link
Collaborator

Datta0 commented Apr 5, 2025

Hey @tamewild can you please add samples of before and after the change?

@mmathew23
Copy link
Collaborator

@danielhanchen @Datta0 This is valid. next(iter(dataset)) gives you the first example, and indexing on dataset_text_field give you the text to tokenize. We don't want the first character we want the whole string in order to check if it startswith the bos_token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tamewild @Datta0 @mmathew23