Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Datta0
Copy link
Collaborator

@Datta0 Datta0 commented Mar 16, 2025

This is to make sure unsloth_compile_cache isn't being duplicated across multiple folders.

@rolandtannous
Copy link
Collaborator

While I understand the appeal of the idea , however i think It's a good idea to keep the cache directory project specific because this maintains a proper separation of concerns but also helps make debugging project specific issues,whose symptoms might surface in a compiled module in the cache directory like in this specific case: unslothai/unsloth#2179, much faster and much cleaner.

@Datta0
Copy link
Collaborator Author

Datta0 commented Apr 7, 2025

Interesting. But if patches don't conflict with other patches, maintaining a global cache is equivalent to maintaining a local cache (even from a debugging perspective)
So I sort of find local cache unnecessary... It creates lot of duplicate folders and hard to keep track of where is what...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants