Ensure we can get the related resource type of tracked fields #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarekwg
reviewed
May 29, 2019
rest_framework_json_api/utils.py
Outdated
| @@ -197,6 +197,13 @@ def get_related_resource_type(relation): | |||
| # For ManyToMany relationships, get the model from the child | |||
| # serializer of the list serializer | |||
| relation_model = relation.child.Meta.model | |||
| # Check fields wrapped in a DescriptorWrapper (tracked fields) | |||
There was a problem hiding this comment.
I'd be a little clearer here and explicitly name django-model-utils and FieldTracker.
b491651 to
a11cdbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fields are wrapped in a DescriptorWrapper by django-model-utils and we can't access the underlying field so we need to read the model off of the descriptor.