Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs(SSO): explain SSO filters with RE2 tester - #6297

Open
coolaj86 wants to merge 1 commit into
usememos:mainfrom
coolaj86:feature/sso-re2-tester-isolated
Open

docs(SSO): explain SSO filters with RE2 tester#6297
coolaj86 wants to merge 1 commit into
usememos:mainfrom
coolaj86:feature/sso-re2-tester-isolated

Conversation

@coolaj86

@coolaj86 coolaj86 commented Sep 7, 2026

Copy link
Copy Markdown

Re: #6292

RegExp is a pain to debug - especially since there are so many variants. This gives clear common examples and a link to a tester that supports the same RegExp variant as is expected.

  • Add a Go RE2 examples: ^(alice|bob|chuck)$ and ^[^@]+@example\\.com$
  • Add a link to regex101’s Go RE2 tester.

@coolaj86
coolaj86 requested a review from a team as a code owner September 7, 2026 21:51
@greptile-apps

greptile-apps Bot commented Sep 7, 2026

Copy link
Copy Markdown

Greptile Summary

The PR improves guidance for configuring SSO identifier filters.

  • Adds anchored username and email regular-expression examples.
  • Links to a Go-compatible regex tester from the identifier-filter field.
  • Broadens the shared field description prop to support linked React content.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness or security issues identified.

The UI type widening is compatible with existing rendering, localization falls back to English, and the documented expressions and linked tester align with the backend’s Go regular-expression implementation.

Important Files Changed

Filename Overview
web/src/components/CreateIdentityProviderDialog.tsx Safely broadens description content to ReactNode and adds a valid external tester link without changing SSO enforcement.
web/src/locales/en.json Adds valid anchored RE2 examples and the English label for the tester link.

Reviews (1): Last reviewed commit: "docs(web): explain SSO filters with RE2 ..." | Re-trigger Greptile

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: f994337b-ccba-4293-8a35-1acaf21d80ed

📥 Commits

Reviewing files that changed from the base of the PR and between 805e608 and f5b0441.

📒 Files selected for processing (2)
  • web/src/components/CreateIdentityProviderDialog.tsx
  • web/src/locales/en.json

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


Walkthrough

The identifier filter field now accepts a ReactNode description. Its description includes localized regex examples and a link to regex101.com using the Go RE2 flavor. The link opens in a new tab and uses rel="noreferrer". English localization adds the tool label and expands the description text.

Suggested reviewers: bluedbird, boojack, johnnyjoygh

Merge Risk: ⚪ Minimal · up to f5b04

This change improves SSO identifier-filter guidance with RE2 examples and a safe external testing link. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the SSO filter documentation changes, RE2 examples, and the Regex101 tester link.
Title check ✅ Passed The title clearly identifies the SSO filter documentation update and the RE2 tester link.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@boojack boojack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants