Added a test to indicate the bug.

jgebal · jgebal · commit 099ef71bee78 · 2016-12-13T22:56:08.000Z
diff --git a/tests/RunAll.sql b/tests/RunAll.sql
@@ -40,6 +40,7 @@ create table ut$test_table (val varchar2(1));
 @@lib/RunTest.sql asssertions/ut.expect.to_equal.anydata.PutsObjectStrucureIntoAssert.sql
 @@lib/RunTest.sql asssertions/ut.expect.to_equal.cursor.GivesFailureForDifferentValues.sql
 @@lib/RunTest.sql asssertions/ut.expect.to_equal.cursor.GivesSuccessForEqualValues.sql
+@@lib/RunTest.sql asssertions/ut.expect.to_equal.cursor.ReturnsCursorDataForFailure.sql
 @@lib/RunTest.sql asssertions/ut.expect.to_equal.GivesFailureForDifferentDataTypes.sql
 @@lib/RunTest.sql asssertions/ut.expect.to_equal.GivesFailureForDifferentValues.sql
 @@lib/RunTest.sql asssertions/ut.expect.to_equal.GivesFailureWhenActualIsNull.sql
diff --git a/tests/asssertions/ut.expect.to_equal.cursor.GivesFailureForDifferentValues.sql b/tests/asssertions/ut.expect.to_equal.cursor.GivesFailureForDifferentValues.sql
@@ -6,8 +6,8 @@ declare
   l_result   integer;
 begin
 --Act
-  open l_actual for select * from user_objects;
-  open l_expected for select * from user_objects where rownum <5;
+  open l_actual for select * from user_objects where rownum <=4;
+  open l_expected for select * from user_objects where rownum <=5;
   ut.expect(l_actual).to_equal(l_expected);
   l_result :=  ut_assert_processor.get_aggregate_asserts_result();
 --Assert
diff --git a/tests/asssertions/ut.expect.to_equal.cursor.GivesSuccessForEqualValues.sql b/tests/asssertions/ut.expect.to_equal.cursor.GivesSuccessForEqualValues.sql
@@ -6,8 +6,8 @@ declare
   l_result   integer;
 begin
 --Act
-  open l_actual for select * from user_objects;
-  open l_expected for select * from user_objects;
+  open l_actual for select * from user_objects where rownum <=4;
+  open l_expected for select * from user_objects where rownum <=4;
   ut.expect(l_actual).to_equal(l_expected);
   l_result :=  ut_assert_processor.get_aggregate_asserts_result();
 --Assert
diff --git a/tests/asssertions/ut.expect.to_equal.cursor.ReturnsCursorDataForFailure.sql b/tests/asssertions/ut.expect.to_equal.cursor.ReturnsCursorDataForFailure.sql
@@ -0,0 +1,25 @@
+PROMPT Gives a success when comparing values of different cursors
+--Arrange
+declare
+  l_actual   SYS_REFCURSOR;
+  l_expected SYS_REFCURSOR;
+  l_result   ut_assert_result;
+  l_expected_string  varchar2(32767);
+  l_actual_string    varchar2(32767);
+begin
+--Act
+  open l_actual for select * from user_objects where rownum <=2;
+  open l_expected for select * from user_objects where rownum <=3;
+  ut.expect(l_actual).to_equal(l_expected);
+
+  l_result := treat( ut_assert_processor.get_asserts_results()(1) as ut_assert_result );
+  l_expected_string := l_result.expected_value_string;
+  l_actual_string := l_result.actual_value_string;
+--Assert
+  if nvl(:test_result, ut_utils.tr_success) = ut_utils.tr_success and l_expected_string != 'NULL' and l_actual_string != 'NULL' then
+    :test_result := ut_utils.tr_success;
+  else
+    dbms_output.put_line('expected not null values and got: '''||l_expected_string||''', '''||l_actual_string||'''' );
+  end if;
+end;
+/
