Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 0e72abc

Browse files
committed
Added support for client_character_set as report parameter.
1 parent a4ae4cf commit 0e72abc

3 files changed

Lines changed: 19 additions & 15 deletions

File tree

source/core/coverage/ut_coverage_reporter_base.tpb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,26 +86,26 @@ create or replace type body ut_coverage_reporter_base is
8686
ut_coverage.coverage_pause();
8787
end;
8888

89-
final member function get_report( a_coverage_options ut_coverage_options ) return ut_varchar2_rows pipelined is
89+
final member function get_report( a_coverage_options ut_coverage_options, a_client_character_set varchar2 := null ) return ut_varchar2_rows pipelined is
9090
l_reporter ut_coverage_reporter_base := self;
9191
begin
9292
ut_coverage_helper.cleanup_tmp_table();
9393
(l_reporter as ut_output_reporter_base).before_calling_run(null);
94-
l_reporter.after_calling_run( ut_run( a_coverage_options => a_coverage_options ) );
94+
l_reporter.after_calling_run( ut_run( a_coverage_options => a_coverage_options, a_client_character_set => a_client_character_set ) );
9595
l_reporter.on_finalize(null);
9696
for i in (select x.text from table(l_reporter.get_lines(1, 1)) x ) loop
9797
pipe row (i.text);
9898
end loop;
9999
return;
100100
end;
101101

102-
final member function get_report_cursor( a_coverage_options ut_coverage_options ) return sys_refcursor is
102+
final member function get_report_cursor( a_coverage_options ut_coverage_options, a_client_character_set varchar2 := null ) return sys_refcursor is
103103
l_reporter ut_coverage_reporter_base := self;
104104
l_result sys_refcursor;
105105
begin
106106
ut_coverage_helper.cleanup_tmp_table();
107107
(l_reporter as ut_output_reporter_base).before_calling_run(null);
108-
l_reporter.after_calling_run( ut_run( a_coverage_options => a_coverage_options ) );
108+
l_reporter.after_calling_run( ut_run( a_coverage_options => a_coverage_options, a_client_character_set => a_client_character_set ) );
109109
l_reporter.on_finalize(null);
110110
open l_result for select x.text from table(l_reporter.get_lines(1, 1)) x;
111111
return l_result;

source/core/coverage/ut_coverage_reporter_base.tps

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ create or replace type ut_coverage_reporter_base under ut_output_reporter_base(
3737

3838
overriding final member procedure before_calling_after_all(self in out nocopy ut_coverage_reporter_base, a_executable in ut_executable),
3939
overriding final member procedure after_calling_after_all (self in out nocopy ut_coverage_reporter_base, a_executable in ut_executable),
40-
final member function get_report(a_coverage_options ut_coverage_options ) return ut_varchar2_rows pipelined,
41-
final member function get_report_cursor(a_coverage_options ut_coverage_options ) return sys_refcursor
40+
final member function get_report( a_coverage_options ut_coverage_options, a_client_character_set varchar2 := null ) return ut_varchar2_rows pipelined,
41+
final member function get_report_cursor( a_coverage_options ut_coverage_options, a_client_character_set varchar2 := null ) return sys_refcursor
4242
)
4343
not final not instantiable
4444
/

test/ut3_user/reporters/test_coverage/test_coverage_standalone.pkb

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
create or replace package body test_coverage_standalone is
22

3-
function run_coverage_twice(a_overage_run_id raw, a_object_name varchar2) return clob is
3+
function run_coverage_twice(a_overage_run_id raw, a_object_name varchar2, a_charset varchar2) return clob is
44
l_expected clob;
55
l_block_cov clob;
66
l_file_path varchar2(250);
@@ -13,7 +13,7 @@ create or replace package body test_coverage_standalone is
1313
l_block_cov := '<line number="4" hits="5" branch="false"/>';
1414
end if;
1515
l_expected :=
16-
q'[<?xml version="1.0"?>
16+
q'[<?xml version="1.0" encoding="]'||upper(a_charset)||q'["?>
1717
<!DOCTYPE coverage SYSTEM "http://cobertura.sourceforge.net/xml/coverage-04.dtd">
1818
<coverage line-rate="0" branch-rate="0.0" lines-covered="2" lines-valid="2" branches-covered="0" branches-valid="0" complexity="0" version="1" timestamp="%">
1919
<sources>
@@ -41,22 +41,24 @@ create or replace package body test_coverage_standalone is
4141
l_actual ut3_develop.ut_varchar2_list;
4242
l_expected clob;
4343
l_name varchar2(250);
44+
l_charset varchar2(100) := 'ISO-8859-1';
4445
begin
4546
l_name := ut3_tester_helper.coverage_helper.covered_package_name;
4647

4748
--Arrange and Act
48-
l_expected := run_coverage_twice(l_coverage_run_id, l_name);
49+
l_expected := run_coverage_twice(l_coverage_run_id, l_name, l_charset);
4950

5051
select *
5152
bulk collect into l_actual
5253
from
5354
table (
54-
ut3_develop.ut_coverage_cobertura_reporter( ).get_report(
55-
ut3_develop.ut_coverage_options(
55+
ut3_develop.ut_coverage_cobertura_reporter().get_report(
56+
a_coverage_options => ut3_develop.ut_coverage_options(
5657
coverage_run_id => l_coverage_run_id,
5758
include_objects => ut3_develop.ut_varchar2_rows(l_name),
5859
schema_names => ut3_develop.ut_varchar2_rows('UT3_DEVELOP')
59-
)
60+
),
61+
a_client_character_set => l_charset
6062
)
6163
);
6264

@@ -70,19 +72,21 @@ create or replace package body test_coverage_standalone is
7072
l_actual ut3_develop.ut_varchar2_list;
7173
l_expected clob;
7274
l_name varchar2(250);
75+
l_charset varchar2(100) := 'ISO-8859-1';
7376
begin
7477
l_name := ut3_tester_helper.coverage_helper.covered_package_name;
7578

7679
--Arrange and Act
77-
l_expected := run_coverage_twice(l_coverage_run_id, l_name);
80+
l_expected := run_coverage_twice(l_coverage_run_id, l_name, l_charset);
7881

7982
l_coverage_cursor :=
8083
ut3_develop.ut_coverage_cobertura_reporter( ).get_report_cursor(
81-
ut3_develop.ut_coverage_options(
84+
a_coverage_options => ut3_develop.ut_coverage_options(
8285
coverage_run_id => l_coverage_run_id,
8386
include_objects => ut3_develop.ut_varchar2_rows(l_name),
8487
schema_names => ut3_develop.ut_varchar2_rows('UT3_DEVELOP')
85-
)
88+
),
89+
a_client_character_set => l_charset
8690
);
8791
fetch l_coverage_cursor bulk collect into l_actual;
8892
close l_coverage_cursor;

0 commit comments

Comments
 (0)