Increase allowed chars for annotation name to 250

pesse · Samuel Nitsche · commit 14ed18c38343 · 2017-08-18T10:28:47.000+02:00
Fixes #459 Added additional test to prevent error in future
diff --git a/source/core/ut_annotations.pks b/source/core/ut_annotations.pks
@@ -24,7 +24,7 @@ create or replace package ut_annotations authid current_user as
   */
 
   subtype t_annotation_name is varchar2(1000);
-  subtype t_procedure_name  is varchar2(30);
+  subtype t_procedure_name  is varchar2(250);
 
   /*
     type: typ_annotation_param
diff --git a/tests/RunAll.sql b/tests/RunAll.sql
@@ -50,6 +50,7 @@ exec ut_coverage.coverage_start_develop();
 @@lib/RunTest.sql ut_annotations/ut_annotations.parse_package_annotations.ParsePackageLevelAnnotationWithMultilineComment.sql
 @@lib/RunTest.sql ut_annotations/ut_annotations.parse_package_annotations.spaceBeforeAnnotationParams.sql
 @@lib/RunTest.sql ut_annotations/ut_annotations.parse_package_annotations.ParseAnnotationWithWindowsNewline.sql
+@@lib/RunTest.sql ut_annotations/ut_annotations.parse_package_annotations.ParseProcedureAnnotationWithVeryLongName.sql
 @@lib/RunTest.sql ut_expectation_processor/who_called_expectation.parseStackTrace.sql
 @@lib/RunTest.sql ut_expectation_processor/who_called_expectation.parseStackTraceWith0x.sql
 @@ut_expectations/ut.expect.not_to_be_null.sql
diff --git a/tests/ut_annotations/ut_annotations.parse_package_annotations.ParseProcedureAnnotationWithVeryLongName.sql b/tests/ut_annotations/ut_annotations.parse_package_annotations.ParseProcedureAnnotationWithVeryLongName.sql
@@ -0,0 +1,43 @@
+PROMPT Parse PROCEDURE Annotation with very long name
+
+--Arrange
+declare
+  l_source clob;
+  l_parsing_result ut_annotations.typ_annotated_package;
+  l_expected ut_annotations.typ_annotated_package;
+  l_ann_param ut_annotations.typ_annotation_param;
+
+begin
+  l_source := 'PACKAGE test_tt AS
+  -- %suite
+  -- %displayname(Name of suite)
+  -- %suitepath(all.globaltests)
+
+  --%test
+  procedure very_long_procedure_name_valid_for_oracle_12_so_utplsql_should_allow_it_definitely_well_still_not_reached_128_but_wait_we_ditit;
+END;';
+
+--Act
+  l_parsing_result := ut_annotations.parse_package_annotations(l_source);
+
+--Assert
+  l_ann_param := null;
+  l_ann_param.val := 'Name of suite';
+  l_expected.package_annotations('suite').params := cast( null as ut_annotations.tt_annotation_params);
+  l_expected.package_annotations('displayname').params(1) := l_ann_param;
+  
+  l_ann_param := null;
+  l_ann_param.val := 'all.globaltests';
+  l_expected.package_annotations('suitepath').params(1) := l_ann_param;
+
+  l_expected.procedure_annotations(1).name := 'very_long_procedure_name_valid_for_oracle_12_so_utplsql_should_allow_it_definitely_well_still_not_reached_128_but_wait_we_ditit';
+  l_expected.procedure_annotations(1).annotations('test').params := cast( null as ut_annotations.tt_annotation_params);
+
+  check_annotation_parsing(l_expected, l_parsing_result);
+
+  if ut_expectation_processor.get_status = ut_utils.tr_success then
+    :test_result := ut_utils.tr_success;
+  end if;
+
+end;
+/
