Renamed ut_junit_reporter to ut_xunit_reporter

jgebal · jgebal · commit 15562f8a05a3 · 2017-01-09T22:39:47.000Z
diff --git a/client_source/sqlplus/ut_run.sql b/client_source/sqlplus/ut_run.sql
@@ -24,9 +24,9 @@ Parameters:
                      A textual pretty-print of unit test results (usually use for console output)
                    -f=ut_teamcity_reporter
                      A teamcity Unit Test reporter, that can be used to visualize progress of test execution as the job progresses.
-                   -f=ut_junit_reporter
-                     A junit xml format (as defined at: http://stackoverflow.com/a/9691131 and at https://gist.github.com/kuzuha/232902acab1344d6b578)
-                     Usually used for consumption by Continuous Integration servers like Jenkins/Hudson or Teamcity
+                   -f=ut_xunit_reporter
+                     A XUnit xml format (as defined at: http://stackoverflow.com/a/9691131 and at https://gist.github.com/kuzuha/232902acab1344d6b578)
+                     Usually used  by Continuous Integration servers like Jenkins/Hudson or Teamcity to display test results.
                  If no -f option is provided, the ut_documentation_reporter will be used.
 
   -o=output    - file name to save the output provided by the reporter.
diff --git a/readme.md b/readme.md
@@ -55,10 +55,10 @@ The following table is a work in progress right now, and **will** change.   If y
 | Multiple Output Reporters can be used during test execution | No | Yes |
 | DBMS_OUTPUT               | Yes           | Yes (format changed)   |
 | Stored in Table           | Yes           | On Roadmap             |
-| JUnit XML Format          | No            | On Roadmap             |
+| XUnit XML Format          | No            | Yes                    |
 | HTML Format               | Yes           | On Roadmap             |
 | File                      | Yes           | On Roadmap             |
-| Realtime test execution results | No       | On Roadmap             |
+| Realtime test execution results | No       | Yes             |
 | Custom Output reporter    | Yes           | Yes                    |
 
 <sup>1</sup> Annotations are specially formatted comments in your package specification.  This enables *declarative* test configuration that is coupled with the source code.   See Documentation for more details. 
diff --git a/source/install.sql b/source/install.sql
@@ -165,8 +165,8 @@ whenever oserror exit failure rollback
 @@reporters/ut_teamcity_reporter_helper.pks
 @@reporters/ut_teamcity_reporter_helper.pkb
 @@reporters/ut_teamcity_reporter.tpb
-@@reporters/ut_junit_reporter.tps
-@@reporters/ut_junit_reporter.tpb
+@@reporters/ut_xunit_reporter.tps
+@@reporters/ut_xunit_reporter.tpb
 
 set linesize 200
 column text format a100
diff --git a/source/reporters/ut_junit_reporter.tps b/source/reporters/ut_junit_reporter.tps
diff --git a/source/reporters/ut_xunit_reporter.tpb b/source/reporters/ut_xunit_reporter.tpb
@@ -1,13 +1,13 @@
-create or replace type body ut_junit_reporter is
+create or replace type body ut_xunit_reporter is
 
-  constructor function ut_junit_reporter(a_output ut_output default ut_output_dbms_output()) return self as result is
+  constructor function ut_xunit_reporter(a_output ut_output default ut_output_dbms_output()) return self as result is
   begin
     self.name   := $$plsql_unit;
     self.output := a_output;
     return;
   end;
 
-  overriding member procedure after_calling_run(self in out nocopy ut_junit_reporter, a_run in ut_run) is
+  overriding member procedure after_calling_run(self in out nocopy ut_xunit_reporter, a_run in ut_run) is
     l_suite_id    integer := 0;
     l_tests_count integer := a_run.results_count.ignored_count + a_run.results_count.success_count + a_run.results_count.failure_count + a_run.results_count.errored_count;
 
@@ -18,9 +18,6 @@ create or replace type body ut_junit_reporter is
 
     procedure print_test_elements(a_test ut_test) is
     begin
-      --     http://stackoverflow.com/questions/4922867/junit-xml-format-specification-that-hudson-supports
-      --     http://stackoverflow.com/questions/8079071/xml-format-specification-dtd-xsd-for-unit-test-reports
-      --     https://gist.github.com/kuzuha/232902acab1344d6b578
       self.print_text(
           '<testcase classname="'||get_path(a_test.path, a_test.name)||'" ' ||
           ' assertions="'||a_test.results.count||'"' ||
diff --git a/source/reporters/ut_xunit_reporter.tps b/source/reporters/ut_xunit_reporter.tps
@@ -0,0 +1,14 @@
+create or replace type ut_xunit_reporter under ut_reporter_base
+(
+  /**
+   * The XUnit reporter.
+   * Provides outcomes in a format conforming with JUnit4 as defined in:
+   *  https://gist.github.com/kuzuha/232902acab1344d6b578
+   */
+  constructor function ut_xunit_reporter(a_output ut_output default ut_output_dbms_output()) return self as result,
+
+  overriding member procedure after_calling_run(self in out nocopy ut_xunit_reporter, a_run in ut_run),
+  member function get_common_item_attributes(a_item ut_suite_item) return varchar2
+)
+not final
+/
diff --git a/source/uninstall.sql b/source/uninstall.sql
@@ -104,7 +104,7 @@ drop type ut_documentation_reporter;
 
 drop type ut_teamcity_reporter;
 
-drop type ut_junit_reporter;
+drop type ut_xunit_reporter;
 
 drop type ut_event_listener;
 
