Adressed code review comments. Clob variable changed to varchar2 variable.

jgebal · jgebal · commit 1b8f3c808823 · 2016-11-27T12:10:50.000Z
Fixed varuable naming. Removed select statement that is no longer needed.
diff --git a/source/core/types/ut_output_dbms_output.tpb b/source/core/types/ut_output_dbms_output.tpb
@@ -18,11 +18,11 @@ create or replace type body ut_output_dbms_output as
   end;
 
   overriding member procedure send_clob(self in out nocopy ut_output_dbms_output, a_text clob) is
-    v_buffer ut_varchar2_list;
+    l_buffer ut_varchar2_list;
   begin
-    v_buffer := ut_utils.clob_to_table(a_text);
-    for i in 1 .. v_buffer.count loop
-      dbms_output.put_line(v_buffer(i));
+    l_buffer := ut_utils.clob_to_table(a_text);
+    for i in 1 .. l_buffer.count loop
+      dbms_output.put_line(l_buffer(i));
     end loop;
   end;
 
@@ -32,15 +32,15 @@ create or replace type body ut_output_dbms_output as
   end;
 
   overriding final member function get_lines(a_output_id varchar2) return ut_varchar2_list pipelined is
-    l_buffer clob;
-    l_status integer;
+    l_buffer          varchar2(32767);
+    l_status          integer;
     c_max_line_length constant integer := 4000;
     l_results_tab     ut_varchar2_list;
   begin
     loop
       dbms_output.get_line (l_buffer, l_status);
       exit when l_status != 0;
-      select column_value bulk collect into l_results_tab from table( ut_utils.clob_to_table(l_buffer, c_max_line_length));
+      l_results_tab := ut_utils.clob_to_table(l_buffer, c_max_line_length);
       --pipe results one by one
       for i in 1 .. l_results_tab.count loop
         pipe row( l_results_tab(i) );
