addressed reviewer comments

Pazus · Pazus · commit 1d6da239ea52 · 2017-05-29T21:17:59.000+03:00
diff --git a/source/core/ut_expectation_processor.pkb b/source/core/ut_expectation_processor.pkb
@@ -126,14 +126,11 @@ create or replace package body ut_expectation_processor as
     l_caller_type_and_name       varchar2(4000);
     l_line_no                    integer;
     l_owner                      varchar2(1000);
-    l_object_name                varchar2(1000);
-    --c_expectation_search_pattern constant varchar2(50) := '(.*\.UT_EXPECTATION_RESULT\s)(.*\.UT_EXPECTATION[A-Z0-9#_$]*\.*\s)+(.*)\s';
-    
+    l_object_name                varchar2(1000);   
     -- in 12.2 format_call_stack reportes not only package name, but also the procedure name
     -- when 11g and 12c reports only package name
     c_expectation_search_pattern constant varchar2(500) := '(.*\.UT_EXPECTATION_RESULT\s+)(.*\.UT_EXPECTATION[A-Z0-9#_$]*(\.\w+)?.*\s+)+(.*)\s';
   begin
-    --dbms_output.put_line(c_call_stack);
     l_caller_stack_line    := regexp_substr( c_call_stack, c_expectation_search_pattern, 1, 1, 'm', 4);
     l_line_no              := to_number( regexp_substr(l_caller_stack_line,'^\dx[0-9a-f]+\s+(\d+)',subexpression => 1) );
     l_caller_type_and_name    := substr( l_caller_stack_line, 23 );
diff --git a/tests/RunAll.sql b/tests/RunAll.sql
@@ -129,7 +129,7 @@ exec ut_coverage.coverage_start_develop();
 
 @@lib/RunTest.sql ut_reporters/ut_coverage_sonar_reporter.AcceptsFileMapping.sql
 @@lib/RunTest.sql ut_reporters/ut_coverage_sonar_reporter.BuildsSonarCoverageReport.sql
-@@lib/RunTest.sql ut_reporters/ut_documentation_reporter.ProducesExpectedOutputs.sql
+@@lib/RunTest.sql ut_reporters/ut_documentation_reporter.providesCorrectLineFromStacktrace.sql
 @@lib/RunTest.sql ut_reporters/ut_sonar_test_reporter.AcceptsFileMapping.sql
 @@lib/RunTest.sql ut_reporters/ut_sonar_test_reporter.ProducesExpectedOutputs.sql
 @@lib/RunTest.sql ut_reporters/ut_teamcity_reporter.ProducesExpectedOutputs.sql
diff --git a/tests/ut_reporters/ut_documentation_reporter.providesCorrectLineFromStacktrace.sql b/tests/ut_reporters/ut_documentation_reporter.providesCorrectLineFromStacktrace.sql
