Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 332cf6f

Browse files
jgebaljgebal
committed
Fixed failing examples and tests.
1 parent 2a32620 commit 332cf6f

7 files changed

Lines changed: 27 additions & 15 deletions

File tree

‎examples/developer_examples/RunExampleTestSuite.sql‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ begin
4444
dbms_output.put_line('Test:' || test_item.item.form_name);
4545
dbms_output.put_line('Result: ' || ut_utils.test_result_to_char(test_item.result));
4646
dbms_output.put_line('expectation Results:');
47-
for i in test_item.results.first .. test_item.results.last loop
47+
for i in 1 .. test_item.results.count loop
4848
expectation := test_item.results(i);
4949
dbms_output.put_line(i || ' - result: ' || ut_utils.test_result_to_char(expectation.result));
5050
dbms_output.put_line(i || ' - Message: ' || expectation.message);

‎old_tests/ut_expectations/ut.expect.to_equal.with_text.GivesTheProvidedTextAsMessage.sql‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'blob' 'to_blob(''abc'')' 'to_blob(''abc'')'"
2-
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'boolean' 'true' 'true'"
3-
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'clob' '''abc''' '''abc'''"
4-
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'date' 'sysdate' 'sysdate'"
5-
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'number' '1' '1'"
6-
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'timestamp' 'sysdate' 'sysdate'"
7-
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'timestamp with local time zone' 'sysdate' 'sysdate'"
8-
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'timestamp with time zone' 'sysdate' 'sysdate'"
9-
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'varchar2(100)' '''abc''' '''abc'''"
10-
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'interval day to second' '''2 01:00:00''' '''2 01:00:00'''"
11-
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'interval year to month' '''1-1''' '''1-1'''"
1+
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'blob' 'to_blob(''abcd'')' 'to_blob(''abc'')'"
2+
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'boolean' 'false' 'true'"
3+
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'clob' '''abcd''' '''abc'''"
4+
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'date' 'sysdate-1' 'sysdate'"
5+
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'number' '2' '1'"
6+
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'timestamp' 'sysdate-1' 'sysdate'"
7+
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'timestamp with local time zone' 'sysdate-1' 'sysdate'"
8+
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'timestamp with time zone' 'sysdate-1' 'sysdate'"
9+
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'varchar2(100)' '''abcd''' '''abc'''"
10+
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'interval day to second' '''2 01:01:00''' '''2 01:00:00'''"
11+
@@lib/RunTest.sql "ut_expectations/common/ut.expect.to_equal.scalar.with_message.common.sql 'interval year to month' '''1-2''' '''1-1'''"
1212

1313

1414

‎source/core/types/ut_test.tpb‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ create or replace type body ut_test as
9999
self.result := ut_utils.tr_error;
100100
end if;
101101
--expectation results need to be part of test results
102+
self.expectations_count := ut_expectation_processor.get_expectations_count();
102103
self.results := ut_expectation_processor.get_expectations_results();
103104
self.results_count.set_counter_values(self.result);
104105
end;

‎source/core/types/ut_test.tps‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,14 @@ create or replace type ut_test under ut_suite_item (
4040
*/
4141
after_each ut_executable,
4242
/**
43-
* The list of expectation results as well as database errors encountered while invoking
43+
* The list of failed expectation results as well as database errors encountered while invoking
4444
* The test procedure and the before_test/after_test blocks
4545
*/
46-
results ut_expectation_results,
46+
results ut_expectation_results,
47+
/**
48+
* The count of all expectations executed in the test
49+
*/
50+
expectations_count integer,
4751
parent_error_stack_trace varchar2(4000),
4852
constructor function ut_test(
4953
self in out nocopy ut_test, a_object_owner varchar2 := null, a_object_name varchar2, a_name varchar2, a_description varchar2 := null,

‎source/core/ut_expectation_processor.pkb‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,11 @@ create or replace package body ut_expectation_processor as
5252
g_expectations_called.delete;
5353
end;
5454

55+
function get_expectations_count return integer is
56+
begin
57+
return g_expectations_called.count;
58+
end;
59+
5560
function get_expectations_results return ut_expectation_results is
5661
l_expectations_results ut_expectation_results := ut_expectation_results();
5762
begin

‎source/core/ut_expectation_processor.pks‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ create or replace package ut_expectation_processor authid current_user as
2828

2929
procedure clear_expectations;
3030

31+
function get_expectations_count return integer;
32+
3133
function get_expectations_results return ut_expectation_results;
3234

3335
procedure add_expectation_result(a_expectation_result ut_expectation_result);

‎source/reporters/ut_xunit_reporter.tpb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ create or replace type body ut_xunit_reporter is
3737
l_output clob;
3838
begin
3939
self.print_text('<testcase classname="' || dbms_xmlgen.convert(get_path(a_test.path, a_test.name)) || '" ' || ' assertions="' ||
40-
coalesce(cardinality(a_test.results), 0) || '"' || self.get_common_item_attributes(a_test) || case when
40+
nvl(a_test.expectations_count,0) || '"' || self.get_common_item_attributes(a_test) || case when
4141
a_test.result != ut_utils.tr_success then
4242
' status="' || ut_utils.test_result_to_char(a_test.result) || '"' end || '>');
4343
if a_test.result = ut_utils.tr_disabled then

0 commit comments

Comments
 (0)