Update documentation and added additional test.

lwasylow · lwasylow · commit 42563e90b1f0 · 2018-11-01T20:19:12.000Z
diff --git a/docs/userguide/expectations.md b/docs/userguide/expectations.md
@@ -443,9 +443,42 @@ The matcher supports all advanced comparison options as `equal` e.g. include , e
 
 The matcher will be successful only when all of the values in expected results are part of actual set.
 
+In situation where the duplicate is present in expected set we would also expect matching number of occurrences in actual set for matcher to be success.
+
+*Example 1*
+
+```sql
+   PROCEDURE ut_refcursors IS
+    l_actual   SYS_REFCURSOR;
+    l_expected SYS_REFCURSOR;
+  begin
+    --Arrange
+    open l_actual  for select rownum as rn  from dual a connect by level < 10;
+    open l_expected for select rownum as rn from dual a connect by level < 4
+    union all select rownum as rn from dual a connect by level < 4;
+    
+    --Act
+    ut.expect(l_actual).to_include(l_expected);
+   END;
+```
+
+Will result in failure message
+
+```sql
+  1) ut_refcursors
+      Actual: refcursor [ count = 9 ] was expected to include: refcursor [ count = 6 ]
+      Diff:
+      Rows: [ 3 differences ]
+      Missing:  <ROW><RN>3</RN></ROW>
+      Missing:  <ROW><RN>2</RN></ROW>
+      Missing:  <ROW><RN>1</RN></ROW>
+```
+
+
+
 Similar negated `not_to_include`/ `not_to_contain` will be successful only when none of the values from expected set are part of actual e.g.
 
-*Example 1.*
+*Example 2.*
 
 Set 1 is defined as [ A , B , C ] 
 
diff --git a/test/core/expectations/test_expectations_cursor.pkb b/test/core/expectations/test_expectations_cursor.pkb
@@ -2420,6 +2420,47 @@ Diff:%
     --Assert
     ut.expect(expectations.failed_expectations_data()).to_be_empty();
   end;
+ 
+  procedure to_include_duplicates is
+    l_actual   SYS_REFCURSOR;
+    l_expected SYS_REFCURSOR;
+  begin
+    --Arrange
+    open l_actual  for select rownum as rn  from dual a connect by level < 10
+                       union all 
+                       select rownum as rn from dual a connect by level < 4;
+    open l_expected for select rownum as rn from dual a connect by level < 4;
+    
+    --Act
+    ut3.ut.expect(l_actual).to_include(l_expected);
+    --Assert
+    ut.expect(expectations.failed_expectations_data()).to_be_empty();
+  end;
+  
+  procedure to_include_duplicates_fail is
+    l_actual   SYS_REFCURSOR;
+    l_expected SYS_REFCURSOR;
+    l_expected_message varchar2(32767);
+    l_actual_message   varchar2(32767);
+  begin
+    --Arrange
+    open l_actual  for select rownum as rn  from dual a connect by level < 10;
+    open l_expected for select rownum as rn from dual a connect by level < 4
+    union all select rownum as rn from dual a connect by level < 4;
+    
+    --Act
+    ut3.ut.expect(l_actual).to_include(l_expected);
+   --Assert
+     l_expected_message := q'[%Actual: refcursor [ count = 9 ] was expected to include: refcursor [ count = 6 ]
+%Diff:
+%Rows: [ 3 differences ]
+%Missing:  <ROW><RN>%</RN></ROW>
+%Missing:  <ROW><RN>%</RN></ROW>
+%Missing:  <ROW><RN>%</RN></ROW>]';
+    l_actual_message := ut3.ut_expectation_processor.get_failed_expectations()(1).message;
+    --Assert
+    ut.expect(l_actual_message).to_be_like(l_expected_message);
+  end;
   
 end;
 /
diff --git a/test/core/expectations/test_expectations_cursor.pks b/test/core/expectations/test_expectations_cursor.pks
@@ -387,6 +387,12 @@ create or replace package test_expectations_cursor is
   
   --%test(Cursor not contains data with of columns to exclude and join by value)
   procedure not_cont_join_excl_cols_as_lst; 
+
+  --%test(Cursor to include duplicates)
+  procedure to_include_duplicates;
+  
+  --%test(Cursor to include duplicates fail)
+  procedure to_include_duplicates_fail;
   
 end;
 /
