changed for loop to open-fetch-close routine to prevent optimization

Pazus · Pazus · commit 74362775dfdf · 2016-12-26T23:56:23.000+03:00
diff --git a/source/core/types/ut_output_stream.tpb b/source/core/types/ut_output_stream.tpb
@@ -2,29 +2,48 @@ create or replace type body ut_output_stream as
 
   overriding final member procedure close(self in out nocopy ut_output_stream) is
   begin
-    self.close( a_timeout_sec=>60 );
+    self.close(a_timeout_sec => 60);
   end;
 
-  overriding final member function get_lines(a_output_id varchar2) return ut_varchar2_list pipelined is
+  overriding final member function get_lines(a_output_id varchar2) return ut_varchar2_list
+    pipelined is
+    cursor l_cur is
+      select column_value from table(self.get_lines(a_output_id, 60 * 60 * 4));
+    l_col_value varchar2(32767);
   begin
-    for i in ( select column_value from table( self.get_lines(a_output_id, 60*60*4) ) ) loop
-      pipe row(i.column_value);
+    open l_cur;
+  
+    -- open-fetch-close routine is used to prevent optimization as we need row by row quering
+    loop
+      fetch l_cur
+        into l_col_value;
+      exit when l_cur%notfound;
+      pipe row(l_col_value);
     end loop;
+  
+    close l_cur;
     return;
   end;
 
-  overriding final member function get_clob_lines(a_output_id varchar2) return ut_clob_list pipelined is
+  overriding final member function get_clob_lines(a_output_id varchar2) return ut_clob_list
+    pipelined is
+    cursor l_cur is
+      select column_value from table(self.get_clob_lines(a_output_id, 60 * 60 * 4));
+    l_col_value clob;
   begin
-    for i in ( select column_value from table( self.get_clob_lines(a_output_id, 60*60*4) ) ) loop
-      pipe row(i.column_value);
+    open l_cur;
+  
+    -- open-fetch-close routine is used to prevent optimization as we need row by row quering
+    loop
+      fetch l_cur
+        into l_col_value;
+      exit when l_cur%notfound;
+      pipe row(l_col_value);
     end loop;
+  
+    close l_cur;
     return;
   end;
 
 end;
 /
---we need to use plsql optimize level=1 to prevent
--- Oracle from changing the for loop to bulk collect into
--- The row-by-row approach is needed to get the visible progress ot unit tests outputs
---  as the tests get executed.
-alter type ut_output_stream compile body plsql_optimize_level = 1;
