small improvments

lwasylow · lwasylow · commit 7a77a7f260d8 · 2019-03-08T10:07:31.000Z
diff --git a/source/expectations/data_values/ut_compound_data_helper.pkb b/source/expectations/data_values/ut_compound_data_helper.pkb
@@ -401,7 +401,7 @@ create or replace package body ut_compound_data_helper is
       select
           exp_item_data, exp_data_id, item_no rn, rownum col_no, pk_value,
           s.column_value col, s.column_value.getRootElement() col_name,
-          s.column_value.getclobval() col_val
+          nvl(s.column_value.getclobval(),empty_clob()) col_val
         from (
           select
               exp_data_id, extract( ucd.exp_item_data, :column_path ) exp_item_data, item_no,
@@ -416,7 +416,7 @@ create or replace package body ut_compound_data_helper is
       select
           act_item_data, act_data_id, item_no rn, rownum col_no, pk_value,
           s.column_value col, s.column_value.getRootElement() col_name,
-          s.column_value.getclobval() col_val
+          nvl(s.column_value.getclobval(),empty_clob()) col_val
         from (
           select
               act_data_id, extract( ucd.act_item_data, :column_path ) act_item_data, item_no,
diff --git a/source/expectations/matchers/ut_equal.tpb b/source/expectations/matchers/ut_equal.tpb
@@ -237,7 +237,6 @@ create or replace type body ut_equal as
     l_result varchar2(32767);
   begin
     if self.expected.data_type = a_actual.data_type and self.expected.is_diffable then
-     --TODO : Refactor
       if self.expected is of (ut_data_value_refcursor) then
         l_result :=
           'Actual: '||a_actual.get_object_info()||' '||self.description()||': '||self.expected.get_object_info()
diff --git a/test/core/expectations/test_expectations_cursor.pkb b/test/core/expectations/test_expectations_cursor.pkb
@@ -2465,5 +2465,19 @@ Diff:%
     ut.expect(l_actual_message).to_be_like(l_expected_message);
   end;
   
+  procedure fixes_827_null_on_lob_compare is
+    l_actual   sys_refcursor;
+    l_expected sys_refcursor;
+  begin
+    --Arrange
+    open l_actual for select rownum as rn, case when rownum = 2 then null else 'Row'||rownum end as rowdesc   
+      from dual a connect by level < 3;
+    open l_expected  for select rownum as rn, 'Row'||rownum as rowdesc  from dual a connect by level < 3;
+    
+    ut3.ut.expect(l_actual).to_equal(l_expected);
+    --Assert
+    ut.expect(expectations.failed_expectations_data()).to_be_empty();
+  end;  
+  
 end;
 /
diff --git a/test/core/expectations/test_expectations_cursor.pks b/test/core/expectations/test_expectations_cursor.pks
@@ -391,5 +391,8 @@ create or replace package test_expectations_cursor is
   --%test(Cursor to contain duplicates fail)
   procedure to_contain_duplicates_fail;
   
+  --%test( Fixes error 827 when lob compare fails on null)
+  procedure fixes_827_null_on_lob_compare;
+  
 end;
 /

Original file line number	Diff line number	Diff line change
`@@ -391,5 +391,8 @@ create or replace package test_expectations_cursor is`
`391`	`391`	`--%test(Cursor to contain duplicates fail)`
`392`	`392`	`procedure to_contain_duplicates_fail;`
`393`	`393`
	`394`	`+ --%test( Fixes error 827 when lob compare fails on null)`
	`395`	`+ procedure fixes_827_null_on_lob_compare;`
	`396`	`+`
`394`	`397`	`end;`
`395`	`398`	`/`