Changed solution for savepoints on distributed transactions.

jgebal · jgebal · commit 8a90ef842745 · 2019-03-14T16:30:18.000Z
Solution with DBMS_SESSION was causing instability on 18c (hanging builds).
diff --git a/source/core/types/ut_suite_item.tpb b/source/core/types/ut_suite_item.tpb
@@ -54,7 +54,7 @@ create or replace type body ut_suite_item as
   begin
     if get_rollback_type() = ut_utils.gc_rollback_auto then
       l_savepoint := ut_utils.gen_savepoint_name();
-      dbms_transaction.savepoint(l_savepoint);
+      execute immediate 'savepoint ' || l_savepoint;
     end if;
     return l_savepoint;
   end;
@@ -65,7 +65,7 @@ create or replace type body ut_suite_item as
     pragma exception_init(ex_savepoint_not_exists, -1086);
   begin
     if get_rollback_type() = ut_utils.gc_rollback_auto and a_savepoint is not null then
-      dbms_transaction.rollback_savepoint( a_savepoint );
+      execute immediate 'rollback to ' || a_savepoint;
     end if;
   exception
     when ex_savepoint_not_exists then
diff --git a/source/core/ut_utils.pkb b/source/core/ut_utils.pkb
@@ -52,7 +52,7 @@ create or replace package body ut_utils is
 
   function gen_savepoint_name return varchar2 is
   begin
-    return '"'|| utl_raw.cast_to_varchar2(utl_encode.base64_encode(sys_guid()))||'"';
+    return 's'||to_char(current_timestamp,'yyyymmddhh24missff6');
   end;
 
   procedure debug_log(a_message varchar2) is
diff --git a/test/api/test_ut_run.pks b/test/api/test_ut_run.pks
@@ -56,7 +56,6 @@ create or replace package test_ut_run is
   --%aftertest(drop_failing_beforeall_suite)
   procedure run_proc_fail_child_suites;
 
-  --%disabled(Checking if disabling the test will help hanging Travis build)
   --%test(Savepoints are working properly on distributed transactions - Issue #839)
   --%beforetest(create_suite_with_link)
   --%aftertest(drop_suite_with_link)
