Update documentation and tests for implicit cursor name.

lwasylow · lwasylow · commit ba8e9e2d3f85 · 2018-04-22T14:47:46.000+01:00
diff --git a/docs/userguide/advanced_data_comparison.md b/docs/userguide/advanced_data_comparison.md
@@ -29,6 +29,7 @@ Each item in the comma separated list can be:
 - an attribute name of object type to be compared   
 - an attribute name of object type within a table of objects to be compared
 - an [XPath](http://zvon.org/xxl/XPathTutorial/Output/example1.html) expression representing column/attribute
+- Include and exclude option will not support implicit colum names that starts with single quota, or in fact any other special characters e.g. <, >, &
 
 Each element in `ut_varchar2_list` nested table can be an item or a comma separated list of items.
 
diff --git a/test/core/expectations/compound_data/test_expectations_cursor.pkb b/test/core/expectations/compound_data/test_expectations_cursor.pkb
@@ -1004,5 +1004,42 @@ Rows: [ 2 differences ]%
     ut.expect(expectations.failed_expectations_data()).to_be_empty();
   end;
     
+    
+  procedure include_col_name_implicit is
+    l_actual   SYS_REFCURSOR;
+    l_expected SYS_REFCURSOR;
+  begin
+    --Arrange
+    open l_actual   for select rownum as rn, 'a', 'c' as A_COLUMN, 'x' SOME_COL, 'd' "Some_Col" from dual a connect by level < 4;
+    open l_expected for select rownum as rn, 'a', 'd' as A_COLUMN, 'x' SOME_COL, 'c' "Some_Col" from dual a connect by level < 4;
+    begin
+      --Act
+      ut3.ut.expect(l_actual).to_equal(l_expected).include(q'!/ROW/RN,'a',//SOME_COL!');
+      --Assert
+      ut.fail('Expected exception but nothing was raised');
+    exception
+      when others then
+        ut.expect(sqlcode).to_be_between(-31013,-31011);
+    end;
+  end;
+
+  procedure exclude_col_name_implicit is
+    l_actual   SYS_REFCURSOR;
+    l_expected SYS_REFCURSOR;
+  begin
+    --Arrange
+    open l_actual   for select rownum as rn, 'a', 'c' as A_COLUMN, 'x' SOME_COL, 'd' "Some_Col" from dual a connect by level < 4;
+    open l_expected for select rownum as rn, 'a', 'd' as A_COLUMN, 'x' SOME_COL, 'c' "Some_Col" from dual a connect by level < 4;
+    begin
+      --Act
+      ut3.ut.expect(l_actual).to_equal(l_expected).exclude(q'!/ROW/RN,'a',//SOME_COL!');
+      --Assert
+      ut.fail('Expected exception but nothing was raised');
+    exception
+      when others then
+        ut.expect(sqlcode).to_be_between(-31013,-31011);
+    end;
+  end;
+  
 end;
 /
diff --git a/test/core/expectations/compound_data/test_expectations_cursor.pks b/test/core/expectations/compound_data/test_expectations_cursor.pks
@@ -192,6 +192,12 @@ create or replace package test_expectations_cursor is
 
   --%test(Reports column match on cursor with column name implicit )
   procedure col_mtch_on_col_name_implicit;
-   
+  
+  --%test( Fail on passing implicit column name as include filter )
+  procedure include_col_name_implicit;
+
+  --%test( Fail on passing implicit column name as exclude filter )
+  procedure exclude_col_name_implicit;
+  
 end;
 /
