Resolves issues with teamcity reporter:

jgebal · jgebal · commit c850b38cb631 · 2018-08-11T17:27:09.000+01:00
- the `[` and `]` were not escaped - the `"` was escaped though not needed - If total length of message inside the square brackets exceeds 4000 characters it's causing teamcity to report success for a test failed Resolves #747
diff --git a/source/reporters/ut_teamcity_reporter_helper.pkb b/source/reporters/ut_teamcity_reporter_helper.pkb
@@ -21,7 +21,7 @@ create or replace package body ut_teamcity_reporter_helper is
 
   function escape_value(a_value in varchar2) return varchar2 is
   begin
-    return translate(regexp_replace(a_value, '(''|"|[|]|' || chr(13) || '|' || chr(10) || ')', '|\1'),chr(13)||chr(10),'nr');
+    return translate(regexp_replace(a_value, q'/(\'|\||\[|\]|/' || chr(13) || '|' || chr(10) || ')', '|\1'),chr(13)||chr(10),'rn');
   end;
 
   function message(a_command in varchar2, a_props t_props default cast(null as t_props)) return varchar2 is
@@ -35,7 +35,7 @@ create or replace package body ut_teamcity_reporter_helper is
     l_index := a_props.first;
     while l_index is not null loop
       if a_props(l_index) is not null then
-        l_value   := escape_value(a_props(l_index));
+        l_value   := substr(escape_value(a_props(l_index)),1,2000);
         l_message := l_message || ' ' || l_index || '=''' || l_value || '''';
       end if;
       l_index := a_props.next(l_index);
diff --git a/test/core/reporters.pkb b/test/core/reporters.pkb
@@ -76,7 +76,7 @@ as
   is
   begin
     dbms_output.put_line('<!failing test!>');
-    ut3.ut.expect(1,'Fails as values are different').to_equal(2);
+    ut3.ut.expect('number [1] ','Fails as values are different').to_equal('number [2] ');
   end;
 
   procedure erroring_test
diff --git a/test/core/reporters/test_teamcity_reporter.pkb b/test/core/reporters/test_teamcity_reporter.pkb
@@ -22,14 +22,14 @@ create or replace package body test_teamcity_reporter as
 <!beforeeach!>
 <!failing test!>
 <!aftereach!>
-%##teamcity[testFailed timestamp='%' message='Fails as values are different' name='ut3_tester.test_reporters.failing_test']
+%##teamcity[testFailed timestamp='%' details='Actual: |'number |[1|] |' (varchar2) was expected to equal: |'number |[2|] |' (varchar2) ' message='Fails as values are different' name='ut3_tester.test_reporters.failing_test']
 %##teamcity[testFinished timestamp='%' duration='%' name='ut3_tester.test_reporters.failing_test']
 %##teamcity[testStarted timestamp='%' captureStandardOutput='true' name='ut3_tester.test_reporters.erroring_test']
 <!beforeeach!>
 <!erroring test!>
 <!aftereach!>
-%##teamcity[testStdErr timestamp='%' name='ut3_tester.test_reporters.erroring_test' out='Test exception:|rORA-06512: at |"UT3_TESTER.TEST_REPORTERS|", line %|rORA-06512: at %|r|r']
-%##teamcity[testFailed timestamp='%' details='Test exception:|rORA-06512: at |"UT3_TESTER.TEST_REPORTERS|", line %|rORA-06512: at %|r|r' message='Error occured' name='ut3_tester.test_reporters.erroring_test']
+%##teamcity[testStdErr timestamp='%' name='ut3_tester.test_reporters.erroring_test' out='Test exception:|nORA-06512: at "UT3_TESTER.TEST_REPORTERS", line %|nORA-06512: at %|n|n']
+%##teamcity[testFailed timestamp='%' details='Test exception:|nORA-06512: at "UT3_TESTER.TEST_REPORTERS", line %|nORA-06512: at %|n|n' message='Error occured' name='ut3_tester.test_reporters.erroring_test']
 %##teamcity[testFinished timestamp='%' duration='%' name='ut3_tester.test_reporters.erroring_test']
 %##teamcity[testStarted timestamp='%' captureStandardOutput='true' name='ut3_tester.test_reporters.disabled_test']
 %##teamcity[testIgnored timestamp='%' name='ut3_tester.test_reporters.disabled_test']
