Update to test and docs

lwasylow · lwasylow · commit f77f13abdeb3 · 2018-05-24T20:33:19.000+01:00
diff --git a/docs/userguide/advanced_data_comparison.md b/docs/userguide/advanced_data_comparison.md
@@ -143,6 +143,8 @@ You can now join two cursors by defining a primary key or composite key that wil
 
 Join by option can be used in conjunction with include or exclude options. However if any of the join keys is part of exclude set, comparison will fail and report to user that sets could not be joined on specific key  (excluded).
 
+Join by options currently doesn't support nested table inside cursor.
+
 ```sql
 procedure join_by_username is
     l_actual   sys_refcursor;
diff --git a/test/core/expectations/compound_data/test_expectations_cursor.pkb b/test/core/expectations/compound_data/test_expectations_cursor.pkb
@@ -1696,5 +1696,40 @@ Diff:%
     --Assert
     ut.expect(l_actual_message).to_be_like(l_expected_message);
   end;    
+  
+    procedure comparet_tabtype_as_cols_jb is
+    l_actual   sys_refcursor;
+    l_expected sys_refcursor;
+    l_actual_tab ut3.ut_key_value_pairs := ut3.ut_key_value_pairs();
+    l_expected_tab ut3.ut_key_value_pairs := ut3.ut_key_value_pairs();
+    l_expected_message varchar2(32767);
+    l_actual_message   varchar2(32767);
+  begin
+    select ut3.ut_key_value_pair(rownum,'Something '||rownum)
+    bulk collect into l_actual_tab
+    from dual connect by level <=2;
+ 
+    select ut3.ut_key_value_pair(rownum,'Somethings '||rownum)
+    bulk collect into l_expected_tab
+    from dual connect by level <=2;
+      
+    --Arrange
+    open l_actual for select rownum rn, l_actual_tab
+      from dual connect by level <=2;
+
+    open l_expected for select key,value
+      from table(l_expected_tab) order by 1 desc;
+    
+    --Act
+    ut3.ut.expect(l_actual).to_equal(l_expected).join_by(ut3.ut_varchar2_list('RN,L_ACTUAL_TAB/KEY'));
+    ut3.ut.fail('Expected Exception');
+  exception
+    when others then
+      l_expected_message := q'[%PLS-00306: wrong number or types of arguments in call to 'CONVERTOBJECT'%]';
+      l_actual_message := SQLERRM;
+      --Assert
+      ut.expect(l_actual_message).to_be_like(l_expected_message);
+  end;    
+  
 end;
 /
diff --git a/test/core/expectations/compound_data/test_expectations_cursor.pks b/test/core/expectations/compound_data/test_expectations_cursor.pks
@@ -292,5 +292,8 @@ create or replace package test_expectations_cursor is
   --%test(Compare table type join by multiple columns- Failure)  
   procedure compare_nest_tab_cols_jb_fail;
   
+  --%test(Compare table type as column join by multiple columns - PLS Failure)  
+  procedure comparet_tabtype_as_cols_jb;
+  
 end;
 /

Original file line number	Diff line number	Diff line change
`@@ -292,5 +292,8 @@ create or replace package test_expectations_cursor is`
`292`	`292`	`--%test(Compare table type join by multiple columns- Failure)`
`293`	`293`	`procedure compare_nest_tab_cols_jb_fail;`
`294`	`294`
	`295`	`+ --%test(Compare table type as column join by multiple columns - PLS Failure)`
	`296`	`+ procedure comparet_tabtype_as_cols_jb;`
	`297`	`+`
`295`	`298`	`end;`
`296`	`299`	`/`