Fix problem with identifying annotations when windows newline is used#435
Merged
jgebal merged 4 commits intoutPLSQL:developfrom Aug 3, 2017
Merged
Fix problem with identifying annotations when windows newline is used#435jgebal merged 4 commits intoutPLSQL:developfrom
jgebal merged 4 commits intoutPLSQL:developfrom
Conversation
…dows newline is used
accidentially changed suffix by using dbForge editor
jgebal
requested changes
Aug 2, 2017
|
|
||
| -- strip everything except the annotation itself (spaces and others) | ||
| l_annotation_str := regexp_substr(l_comment, c_annotation_pattern, 1, 1, modifier => 'i'); | ||
| l_annotation_str := regexp_substr(trim(translate(l_comment, chr(10)||chr(13), ' ')), c_annotation_pattern, 1, 1, modifier => 'i'); |
Member
There was a problem hiding this comment.
I think that it would be better to put the fix into: ut_metadata.get_package_spec_source so that the whole source that we parse have Unix-style end of line.
Member
Author
There was a problem hiding this comment.
Agreed and fixed. Thanks for the hint.
…ested. Can't use translate here but the little slower performance of replace shouldn't be a problem
jgebal
approved these changes
Aug 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had this strange behaviour today in a project where I develop on a windows machine using dbForge