Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix problem with identifying annotations when windows newline is used #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgebal merged 4 commits into from
Aug 3, 2017
Merged

Fix problem with identifying annotations when windows newline is used #435

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
050c4a1
Fix problem with identifying annotations on windows machines when win…
pesse Aug 2, 2017
7699c39
Update RunAll.sql
pesse Aug 2, 2017
bba129d
Merge branch 'develop' into fix_newline_in_annotations
pesse Aug 3, 2017
061cdf3
Moved fix of the issue to ut_metadata.get_package_spec_source as sugg…
Aug 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Moved fix of the issue to ut_metadata.get_package_spec_source as sugg… 
…ested.

Can't use translate here but the little slower performance of replace shouldn't be a problem
  • Loading branch information
Samuel Nitsche committed Aug 3, 2017
commit 061cdf3583e03e7b67165a29629b9eeea83694eb
2 changes: 1 addition & 1 deletion source/core/ut_annotations.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ create or replace package body ut_annotations as
l_comment := a_comments(l_comment_index);

-- strip everything except the annotation itself (spaces and others)
l_annotation_str := regexp_substr(trim(translate(l_comment, chr(10)||chr(13), ' ')), c_annotation_pattern, 1, 1, modifier => 'i');
l_annotation_str := regexp_substr(l_comment, c_annotation_pattern, 1, 1, modifier => 'i');
if l_annotation_str is not null then

l_annotation_params.delete;
Expand Down
2 changes: 1 addition & 1 deletion source/core/ut_metadata.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ create or replace package body ut_metadata as
-- we fetch the source explicitly as dbms_preprocessor is very sow on 12.1 and 12.2 when grabbing the sources.
l_lines := sys.dbms_preprocessor.get_post_processed_source(l_lines);
for i in 1..l_lines.count loop
ut_utils.append_to_clob(l_source, l_lines(i));
ut_utils.append_to_clob(l_source, replace(l_lines(i), chr(13)||chr(10), chr(10)));
end loop;
return l_source;
end;
Expand Down