Smart schema re-parse#117
Merged
jgebal merged 4 commits intoutPLSQL:version3from Dec 12, 2016
Merged
Conversation
`run_schema_suites` `run_schema_suites_static` `run_cur_schema_suites` `run_cur_schema_suites_static`
GolezTrol
approved these changes
Dec 8, 2016
Contributor
GolezTrol
left a comment
There was a problem hiding this comment.
Code looks good to me. Tested it from your branch and it does pick up on test package changes.
jgebal
reviewed
Dec 9, 2016
| --end if; | ||
| config_schema(a_schema_name); | ||
| if not g_schema_suites.exists(a_schema_name) | ||
| or g_schema_suites(a_schema_name).changed_at<nvl(get_schema_max_ddl(a_schema_name), date'2999-12-31') then |
Member
There was a problem hiding this comment.
I would put the NVL into the get_schema_max_ddl.
jgebal
reviewed
Dec 9, 2016
| @@ -1,14 +1,26 @@ | |||
| create or replace package body ut_suite_manager is | |||
|
|
|||
| type tt_schema_suits is table of ut_test_suite index by varchar2(4000 char); | |||
Member
There was a problem hiding this comment.
typo in type name here and in line 5
jgebal
reviewed
Dec 9, 2016
| procedure run_cur_schema_suites_static(a_reporter in ut_reporter, a_force_parse_again boolean default false); | ||
|
|
||
| procedure run(a_path in varchar2, a_reporter in ut_reporter); | ||
| -- to be implemented |
Member
There was a problem hiding this comment.
I would enable this run procedure anyway (even if it only runs for one element of array at the moment).
This way we have a complete API and can start implementing on top of it.
Internal implementation can change for run( list ) later. But if we're OK with the entry point signature, it should be enabled I think.
jgebal
approved these changes
Dec 12, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #114 in a simplified form.
Now schema cache becomes invalidated when the last_ddl_time of any package in the schema change
Also corrected examples to eliminate calls to deprecated procedures:
run_schema_suitesrun_schema_suites_staticrun_cur_schema_suitesrun_cur_schema_suites_static