Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix typo in advanced_data_comparison.md #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2022
Merged

Conversation

kukimik
Copy link
Contributor

@kukimik kukimik commented Dec 6, 2021

Typo (is -> if). This way the sentence makes some sense to me. Hope I got it right.

@jgebal
Copy link
Member

jgebal commented Dec 6, 2021

Actually the documentation is correct in current state.
When you use the contain matcher, the order of rows is ignored

@kukimik
Copy link
Contributor Author

kukimik commented Dec 6, 2021

Then I'd say the sentence is not clear enough; I'm not able to parse it, and even after your comment I'm not sure what is the meaning of this note. Perhaps it can be reworded?

@lwasylow
Copy link
Member

lwasylow commented Dec 6, 2021

I guess it could be reworded to say that when using a contain matcher, the order of data is irrelevant and they are compared similar way when unordered matcher is used.
Certainly the word if is not a right one to use it in this scenario in my opinion.

@kukimik
Copy link
Contributor Author

kukimik commented Dec 17, 2021

I think I got it. The two lines:

join_by matcher is much faster on performing data comparison, consider using join_by over unordered

and

contain matcher is not considering order of compared data-sets. Using unordered makes no difference (it's default)

are two separate sentences. The first line is missing a period at the end. Am I right?

If so, please check the updated commit.

@jgebal jgebal merged commit 6a0fedc into utPLSQL:develop Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants