Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feature/refcursor to string fix #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pazus merged 2 commits into from
Dec 14, 2016
Merged

Feature/refcursor to string fix #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
099ef71
Added a test to indicate the bug.
jgebal Dec 13, 2016
3d32d69
Fixed a bug in cursor reporting.
jgebal Dec 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/expectations/data_values/ut_data_value_refcursor.tpb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ create or replace type body ut_data_value_refcursor as
begin
if self.datavalue is not null then
ut_assert_processor.set_xml_nls_params();
dbms_xmlgen.restartQuery(self.datavalue);
dbms_xmlgen.setMaxRows(self.datavalue, 100);
l_result := dbms_xmlgen.getxml(self.datavalue);
dbms_xmlgen.restartQuery(self.datavalue);
ut_assert_processor.reset_nls_params();
end if;
return ut_utils.to_string(l_result);
Expand Down
1 change: 1 addition & 0 deletions tests/RunAll.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ create table ut$test_table (val varchar2(1));
@@lib/RunTest.sql asssertions/ut.expect.to_equal.anydata.PutsObjectStrucureIntoAssert.sql
@@lib/RunTest.sql asssertions/ut.expect.to_equal.cursor.GivesFailureForDifferentValues.sql
@@lib/RunTest.sql asssertions/ut.expect.to_equal.cursor.GivesSuccessForEqualValues.sql
@@lib/RunTest.sql asssertions/ut.expect.to_equal.cursor.ReturnsCursorDataForFailure.sql
@@lib/RunTest.sql asssertions/ut.expect.to_equal.GivesFailureForDifferentDataTypes.sql
@@lib/RunTest.sql asssertions/ut.expect.to_equal.GivesFailureForDifferentValues.sql
@@lib/RunTest.sql asssertions/ut.expect.to_equal.GivesFailureWhenActualIsNull.sql
Expand Down
4 changes: 2 additions & 2 deletions tests/asssertions/ut.expect.to_equal.cursor.GivesFailureForDifferentValues.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ declare
l_result integer;
begin
--Act
open l_actual for select * from user_objects;
open l_expected for select * from user_objects where rownum <5;
open l_actual for select * from user_objects where rownum <=4;
open l_expected for select * from user_objects where rownum <=5;
ut.expect(l_actual).to_equal(l_expected);
l_result := ut_assert_processor.get_aggregate_asserts_result();
--Assert
Expand Down
4 changes: 2 additions & 2 deletions tests/asssertions/ut.expect.to_equal.cursor.GivesSuccessForEqualValues.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ declare
l_result integer;
begin
--Act
open l_actual for select * from user_objects;
open l_expected for select * from user_objects;
open l_actual for select * from user_objects where rownum <=4;
open l_expected for select * from user_objects where rownum <=4;
ut.expect(l_actual).to_equal(l_expected);
l_result := ut_assert_processor.get_aggregate_asserts_result();
--Assert
Expand Down
25 changes: 25 additions & 0 deletions tests/asssertions/ut.expect.to_equal.cursor.ReturnsCursorDataForFailure.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
PROMPT Gives a success when comparing values of different cursors
--Arrange
declare
l_actual SYS_REFCURSOR;
l_expected SYS_REFCURSOR;
l_result ut_assert_result;
l_expected_string varchar2(32767);
l_actual_string varchar2(32767);
begin
--Act
open l_actual for select * from user_objects where rownum <=2;
open l_expected for select * from user_objects where rownum <=3;
ut.expect(l_actual).to_equal(l_expected);

l_result := treat( ut_assert_processor.get_asserts_results()(1) as ut_assert_result );
l_expected_string := l_result.expected_value_string;
l_actual_string := l_result.actual_value_string;
--Assert
if nvl(:test_result, ut_utils.tr_success) = ut_utils.tr_success and l_expected_string != 'NULL' and l_actual_string != 'NULL' then
:test_result := ut_utils.tr_success;
else
dbms_output.put_line('expected not null values and got: '''||l_expected_string||''', '''||l_actual_string||'''' );
end if;
end;
/