Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix for unit-test results reporting into Sonar #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgebal merged 3 commits into from
Mar 3, 2022
Merged

Fix for unit-test results reporting into Sonar #1199

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d86276
Fix for unit-test results reporting into Sonar
jgebal Mar 2, 2022
a0462a7
Fixing tests after schema rename.
jgebal Mar 2, 2022
6a32fc4
Merge remote-tracking branch 'origin/develop' into feature/fix_sonar_…
jgebal Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing tests after schema rename. 
Make sure SONAR runs, even if build fails.
  • Loading branch information
@jgebal
jgebal committed Mar 2, 2022
commit a0462a7584113c494d37fd2c6ceb1bbfec404b35
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ jobs:

- name: SonarCloud Scan
id: sonar
if: ${{ matrix.db_version_name == '21XE' }}
if: ${{ always() && matrix.db_version_name == '21XE' }}
uses: SonarSource/sonarcloud-github-action@master
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
Expand Down
2 changes: 1 addition & 1 deletion test/ut3_user/api/test_ut_run.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ Failures:%
begin
execute immediate q'[select count(1) from all_objects o where o.owner = :object_owner and o.object_type = 'PACKAGE'
and o.status = 'INVALID' and o.object_name= :object_name]' into l_is_invalid
using 'UT3$USER#','INVALID_PCKAG_THAT_REVALIDATES';
using 'UT3_USER','INVALID_PCKAG_THAT_REVALIDATES';

select * bulk collect into l_results from table(ut3_develop.ut.run('invalid_pckag_that_revalidates'));

Expand Down
28 changes: 14 additions & 14 deletions test/ut3_user/api/test_ut_runner.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ end;';
'dummy_test_package.some_dummy_test_procedure' path, 0 disabled_flag, null disabled_reason,'testtag1,testtag2' tags
from dual;
--Act
open l_actual for select * from table(ut3_develop.ut_runner.get_suites_info('UT3$USER#','DUMMY_TEST_PACKAGE'));
open l_actual for select * from table(ut3_develop.ut_runner.get_suites_info('UT3_USER','DUMMY_TEST_PACKAGE'));
--Assert
ut.expect(l_actual).to_equal(l_expected);
end;
Expand Down Expand Up @@ -571,47 +571,47 @@ end;';
begin
ut.expect(
ut3_develop.ut_runner.is_test(
a_owner => 'UT3$USER#',
a_owner => 'UT3_USER',
a_package_name => 'DUMMY_TEST_PACKAGE',
a_procedure_name => 'SOME_DUMMY_TEST_PROCEDURE'
)
).to_be_true();
ut.expect( ut3_develop.ut_runner.is_test( 'ut3$user#','dummy_test_package','some_dummy_test_procedure' ) ).to_be_true();
ut.expect( ut3_develop.ut_runner.is_test( 'ut3_user','dummy_test_package','some_dummy_test_procedure' ) ).to_be_true();
end;

procedure is_test_false is
begin
ut.expect( ut3_develop.ut_runner.is_test( 'UT3$USER#','DUMMY_TEST_PACKAGE', 'BAD' ) ).to_be_false();
ut.expect( ut3_develop.ut_runner.is_test( 'UT3$USER#','BAD_TEST_PACKAGE', 'some_dummy_test_procedure' ) ).to_be_false();
ut.expect( ut3_develop.ut_runner.is_test( 'UT3$USER#','DUMMY_TEST_PACKAGE', null ) ).to_be_false();
ut.expect( ut3_develop.ut_runner.is_test( 'UT3$USER#',null,'some_dummy_test_procedure' ) ).to_be_false();
ut.expect( ut3_develop.ut_runner.is_test( 'UT3_USER','DUMMY_TEST_PACKAGE', 'BAD' ) ).to_be_false();
ut.expect( ut3_develop.ut_runner.is_test( 'UT3_USER','BAD_TEST_PACKAGE', 'some_dummy_test_procedure' ) ).to_be_false();
ut.expect( ut3_develop.ut_runner.is_test( 'UT3_USER','DUMMY_TEST_PACKAGE', null ) ).to_be_false();
ut.expect( ut3_develop.ut_runner.is_test( 'UT3_USER',null,'some_dummy_test_procedure' ) ).to_be_false();
ut.expect( ut3_develop.ut_runner.is_test( null,'DUMMY_TEST_PACKAGE','some_dummy_test_procedure' ) ).to_be_false();
end;

procedure is_suite_true is
begin
ut.expect(
ut3_develop.ut_runner.is_suite(
a_owner => 'UT3$USER#',
a_owner => 'UT3_USER',
a_package_name => 'DUMMY_TEST_PACKAGE'
)
).to_be_true();

ut.expect( ut3_develop.ut_runner.is_suite( 'ut3$user#','dummy_test_package' ) ).to_be_true();
ut.expect( ut3_develop.ut_runner.is_suite( 'ut3_user','dummy_test_package' ) ).to_be_true();
end;

procedure is_suite_false is
begin
ut.expect( ut3_develop.ut_runner.is_suite( 'UT3$USER#','BAD' ) ).to_be_false();
ut.expect( ut3_develop.ut_runner.is_suite( 'UT3$USER#', null ) ).to_be_false();
ut.expect( ut3_develop.ut_runner.is_suite( 'UT3_USER','BAD' ) ).to_be_false();
ut.expect( ut3_develop.ut_runner.is_suite( 'UT3_USER', null ) ).to_be_false();
ut.expect( ut3_develop.ut_runner.is_suite( null,'DUMMY_TEST_PACKAGE' ) ).to_be_false();
ut.expect( ut3_develop.ut_runner.is_suite( 'UT3$USER#','bad_test_package' ) ).to_be_false();
ut.expect( ut3_develop.ut_runner.is_suite( 'UT3_USER','bad_test_package' ) ).to_be_false();
end;

procedure has_suites_true is
begin
ut.expect( ut3_develop.ut_runner.has_suites( a_owner => 'UT3$USER#' ) ).to_be_true();
ut.expect( ut3_develop.ut_runner.has_suites( 'ut3$user#' ) ).to_be_true();
ut.expect( ut3_develop.ut_runner.has_suites( a_owner => 'UT3_USER' ) ).to_be_true();
ut.expect( ut3_develop.ut_runner.has_suites( 'ut3_user' ) ).to_be_true();
end;

procedure has_suites_false is
Expand Down
4 changes: 2 additions & 2 deletions test/ut3_user/expectations/test_expectations_cursor.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2507,7 +2507,7 @@ Diff:%
begin
l_exp_message :='ORA-20218: SQL exception thrown when fetching data from cursor:
ORA-01476: divisor is equal to zero
at "UT3$USER#.TEST_EXPECTATIONS_CURSOR%", line % ut3_develop.ut.expect(l_actual).to_equal(l_expected);%
at "UT3_USER.TEST_EXPECTATIONS_CURSOR%", line % ut3_develop.ut.expect(l_actual).to_equal(l_expected);%
Check the query and data for errors.';

open l_actual for
Expand All @@ -2532,7 +2532,7 @@ Check the query and data for errors.';

l_exp_message :='ORA-20218: SQL exception thrown when fetching data from cursor:
ORA-01476: divisor is equal to zero
at "UT3$USER#.TEST_EXPECTATIONS_CURSOR%", line % ut3_develop.ut.expect(l_actual).to_equal(l_expected);%
at "UT3_USER.TEST_EXPECTATIONS_CURSOR%", line % ut3_develop.ut.expect(l_actual).to_equal(l_expected);%
Check the query and data for errors.';

open l_expected for
Expand Down