Feature/better examples#123
Merged
Pazus merged 8 commits intoutPLSQL:version3from Dec 15, 2016
jgebal:feature/better_examples
Merged
Feature/better examples#123Pazus merged 8 commits intoutPLSQL:version3from jgebal:feature/better_examples
Pazus merged 8 commits intoutPLSQL:version3from
jgebal:feature/better_examples
Conversation
Pazus
suggested changes
Dec 14, 2016
| @@RunWithDocumentationReporter.sql | ||
|
|
||
| --workaround for suite level cache | ||
| declare d date := sysdate; begin loop exit when d != sysdate; end loop; end; |
Member
There was a problem hiding this comment.
cache invalidation is fixed in another PR, no more need in that
|
|
||
| create table room_contents ( | ||
| contents_key number primary key, | ||
| room_key number, |
Member
There was a problem hiding this comment.
This is a bit simpler:
room_key number references rooms(room_key),
Member
Author
|
I've addressed the review comments. |
Pazus
approved these changes
Dec 15, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those are meant to be real use-case scenarios (a bit vanilla but still usable)