Address issue where the not_to(contain) not run correctly #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thout negated flag set causing refcursor compare sql generated inclusion comparision.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1246 +/- ##
===========================================
+ Coverage 94.86% 94.88% +0.02%
===========================================
Files 108 108
Lines 5105 5106 +1
Branches 23 23
===========================================
+ Hits 4843 4845 +2
+ Misses 255 254 -1
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed! |
jgebal
reviewed
Mar 15, 2023
jgebal
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue where the not_to(contain) executes a negated matcher wi…thout negated flag set causing refcursor compare sql generated inclusion comparision.
fixes #1245