This commit fixes #78 issue.#128
Merged
jgebal merged 7 commits intoutPLSQL:version3from Dec 21, 2016
Merged
Conversation
Member
|
Fixes issue #76 |
Member
|
@proldan can you resolve conflicts? |
jgebal
requested changes
Dec 16, 2016
Member
jgebal
left a comment
There was a problem hiding this comment.
Great contribution, few small issues to address, it's quite perfect except for that.
- Please make sure there are no conflicts on merge
- I'm not sure why travis didn;t pick up your build. Need to make sure it runs without issues.
| tr_failure - one or more asserts failed | ||
| tr_error - exception was raised | ||
| */ | ||
| tr_ignore constant number(1) := 0; -- test/suite was ignored |
| @@ -0,0 +1,20 @@ | |||
|
|
|||
# Conflicts: # source/core/ut_utils.pks # source/expectations/ut_expectation.tps
Pazus
reviewed
Dec 17, 2016
| return coalesce(to_char(a_value,gc_timestamp_format), gc_null_string); | ||
| end; | ||
|
|
||
| function to_string(a_value yminterval_unconstrained) return VARCHAR2 IS |
Member
There was a problem hiding this comment.
according to the naming convention we dont use uppercased keywords
Member
|
Great job, @proldan ! Please address minor comments and PR will be merged. |
Feature/new matchers and data types
Contributor
Author
|
Member
|
@proldan Thank you for the contribution. |
jgebal
approved these changes
Dec 20, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create new matchers:
Create new expectations for intervals: